Comments (5)
This is a good one. The plugin arranges for a "require('angular')" every time "angular" is used as a free variable in a module - this is usually the case with angular modules. But the libraries from the angular team don't use "angular" as a free variable, but "window.angular". So I tried setting "window.angular = require('angular')" whenever "window" is used - but that puts a nice little infinite recursion in the angular.js library itself.
The usual way to get around all this "window.something" with webpack is to go to the npm source instead (works great with react.js for example) - but angular on npm isn't commonjs so that's no use. So it seems that the only realistic options are to:
- ask the user to force dependencies for such badly-behaved modules (shim, essentially)
- add knowledge of ngRoute etc. to the plugin.
Option 1 is a pain for the user. Option 2 seems to be stretching things a little and will likely still leave only option 1 for other 3rd party libraries built the same way.
Of course, there's always option 3 - throw in the towel. Gotta love angular, but I've never seen another framework hate on other ways of doing things (or other libraries) so bad.
from angular-webpack-plugin.
Just look my #17 pull request - the fix is pretty simple)
from angular-webpack-plugin.
I'll be damned - It shouldn't work but it does! I'll need to update the scenario tests and move the "expression window.angular" bit up to the top, but thanks!
from angular-webpack-plugin.
I'm novice at webpack so I'm not sure too. It is just simplified webpack.ProvidePlugin code and it works. Sorry for tests.
from angular-webpack-plugin.
Should be fixed in v0.0.3 (bea1442)
from angular-webpack-plugin.
Related Issues (18)
- Convert camelCase to dash-separated.js
- Failing tests HOT 1
- `npm install` at `/demo` yields `does not satisfy requirements` error HOT 1
- Module not found: Error: a dependency to an entry point is not allowed HOT 1
- dealing with other angular modules installed with bower HOT 3
- Export the module
- Require ui.bootstrap (webpackMissingModule) HOT 4
- Examples & Documentation HOT 6
- Tests do not run with the latest version of webpack HOT 1
- a webpack loader that gets rid of the angular module system HOT 1
- Ignore module name prefix HOT 3
- Add template pre-caching HOT 2
- include ngmin functionality somehow HOT 6
- Add tests that the result works in the browser HOT 2
- Handle multiple modules per file (locally) HOT 2
- The package.json dependencies are very old HOT 3
- Usage example in README HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-webpack-plugin.