stackify / stackify-api-php Goto Github PK

Hi all,

In AbstractTransport.php constructor:

    public function __construct()
    {
        $ds = DIRECTORY_SEPARATOR;
        $this->debugLogPath = realpath(dirname(__FILE__) . "$ds..$ds..") . $ds . 'debug/log.log';
        $this->errorGovernor = new ErrorGovernor();
        // add empty implementation to avoid method calls on non-object
        $this->setMessageBuilder(new NullBuilder());
    }

This debugLogPath is hardcoded with constant value in vendor folder. Maybe its good idea to have configurable variable?

If you are using the library in a vagrant environment with a localized hostname, the 5 second timeout is not enough for the ExecTransport to successfully send the curl payload.

Having the timeout set in the Api class as a constant prevents users from being able to change this option. Could this please be modified to use the options array in the ExecTransport constructor?

In Php8 - we see this issue.