stanislawpolanski / mrnwebapi Goto Github PK

Loading railways associated with station does not seem to work.

Logging SQL to a file may be useful

Consider how to distribute responsibility among the layers.

Variables names in DbStationDataAccessService are not understandable.

Reading single station with full info

Make all the db calls async

As creating url is API-dependant it will be performed in a controller layer.

Both layers use the same models. Data access layer pass full models to logic layer. Those models are filled in logic layer. It couples both layers and make data access layer dependent on the project.

Using #18

Point out core features of the system.

Endpoint with reading types of a station.

Use slash detection instead

All data access services may inherit this. It would hold database context.

Design and develop url creator/builder

Create test also

Analysis & decomposition

Refactor UriRoute so that it uses LINQ streams

"test/route" => Exception?

New project MrnPhotosFiles as a web API project. Separate project within this solution.

Reading and writing

Analysis and decomposition - use endpoints with reading photos from the folder

Rewrite UriRoute tests so that it covers core class not the builder.

No such info in datamodel at all.

ThenUriRoute might be enwrapped with an interface easily.

Such warning appears:

Severity	Code	Description	Project	File	Line	Suppression State

Warning	CS1030	#warning: 'To protect potentially 
sensitive information in your connection string, you
 should move it out of source code. 
See http://go.microsoft.com/fwlink/?LinkId=723263 for guidance on 
storing connection strings.'	MrnWebApi	
C:\Users\Dell\source\repos\mrnwebapi\MrnWebApi\DataAccess\Inner\Scaffold\MRN_developContext.cs	
33	Active

.../Scaffold/DbContext
.../Scaffold/Entities

Download all the photos and copy them into the project.

There will be few services, /api may be changed into /database or sth like that.

Tests might be created

Only GET request allowed - photos will be static data.

Rethink if those layers should be tested (using mocks)

IPathBuilder

Unit tests, mocking

Run a test to assure it is a proper solution

Reorganise files structure. In the root folder it is expected not to have any files. Consider splitting classes into two separate folder: root/Common and root/Layers,

Write unit tests for Route class

Analysis and decomposition

Extract services registering to self-sufficient class

Basic stations reading.

It might be static public (const?)

Decompose adding new station milestone (need to be created first) into particular issues.