Comments (3)
lalexgap
commented on July 28, 2024
I think previous work relied on using TransactionRequest and TransactionResponse which looks like slightly different then using an ethers contract object. Hopefully we can do the same using an ethers Contract? Or maybe we should just switch to using a TransactionRequest and TransactionResponse
from safe-protocol.
geoknee
commented on July 28, 2024
The previous work does use an ethers Contract instance, it just passes the return value (which is a TransactionResponse) into a helper function:
from safe-protocol.
lalexgap
commented on July 28, 2024
Ah good point, I missed that ContractResponse extends TransactionResponse
from safe-protocol.
Related Issues (20)
- Enforce yarn version
- Meaningful solidity errors HOT 2
- Add refunds to prototype
- Add liquidity provider address as contract initialization param on L1 and L2
- Factor out ticket hashing
- Contract fund distribution
- Set up auto-formatting
- Ecosystem background research
- Verify yarn instructions are correct
- Create more realistic testing scenario HOT 2
- Spike: Investigate incentivization
- Add support for L1<->L2 token mapping to L2 contract
- Setup linter/formatter for solidity
- Consider mapping of multiple L2 tokens to the same L1 token
- Edit the SAFE paper to discuss withdrawal and deposit chains as opposed to L2 and L1. HOT 1
- Review SAFE.md
- Spike: Try deploying to optimism testnet HOT 2
- Create Deploy scripts HOT 1
- Fix depositOnExitChain amountReserved to work with multiple token types
- Create separate long running benchmark
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safe-protocol.