steelalloy / bte-tools Goto Github PK

Currently the /cs rails command handles all types of railways, (etc. trains trams, and subways). On very complex sections like stations or crossings there might be some overlaps that can cause issues while building or implementing railways into already build areas.

I suggest ability to use: (notice: the syntax is just example to explain for what i mean)

• individual train type (example: /cs railway=subway <args>)
• combination of types in single command (example: /cs railway=subway <args>,railway=trams <args>)
• commands that differentiate between rails, trams and subways (example: /cs rails <args> /cs subway <args> /cs tram <args>)

this is just and idea, the syntax is just example and it may not be correct to be that way, its not final and I would like to hear feedback, if this would work in practice,

https://wiki.openstreetmap.org/wiki/Key:railway:

is there a way to set specific height up with command /cs rails region u?
For example I'm building a metro and I want outlines in the area that is already full of buildings so parsing data there with block height of 0 or 1 is not practical. what about being able to have option to set heigh option? (50 blocks above surface, -20 blocks bellow surface)

Command

/cs goto Paris

Describe the bug

The Minecraft "Earth" (terraplusplus) coordinates for Paris vary considerably from where BTE-tools thinks Paris should be.

To Reproduce

Steps to reproduce the behavior:

1. /cs goto Paris

2. Note the coordinates.
   

3. Try going to Paris using Open Street Map longitude/latitude for Paris
   

Expected behavior

Note the Minecraft coordinates are completely different between "/cs goto" and "/tpll".

Is your feature request related to a problem? Please describe.
Before v2.0.0, we had the ability to restrict the range of action of the rails and hedges commands to our selection. (This was previously knows as /cs rails regionEdge and /cs hedges regionEdge)
It was very handy for not drawing lines over large areas.

Describe the solution you'd like
Add an option in the JSON object of the different commands to do so: rails, railsnear, hedges, and hedgesnear.
Examples that might be suitable

/cs rails {"restrict":true}
/cs rails {"edges":true}

Additional context
The function that was responsible for this behavior can be found here https://github.com/oganexon/BTE-tools/blob/9a02c4d232a0ba043f6c1ffb49a387c7bc7014d2/src/modules/drawLines.js#L48-L54

This should be easy for the rails and hedges commands as the region is already selected by the user.
For railsnear and hedgesnear it will be harder since a new region has to be created from code (cylindrical I think).

When at Minecraft coordinates that represent the western hemisphere (negative longitude), the rails command sends (0, 0) for the n parameter in the generated OSM query. I think I've traced the problem to OSMcommand.js in the functions findS and findN. Changing norm to just be the first coordinate allowed me to get correct rails results.

I guess since this is in OSMcommand.js, the problem probably extends to all commands, but I haven't tested that.