Giter VIP home page Giter VIP logo

intentions's Introduction

Intentions

CI

Intentions is a base package that provides an easy-to-use API to show intentions based in Atom.

Usage

  • Use ALT+ENTER to open the intensions list and press ENTER (or select by mouse) to choose the action.
  • To see the all available actions hold CTRL (⌘ on macOS).

intentions-list

vim-mode-plus users can add these keymap entries to use j and k to navigate the actions list

'atom-text-editor.intentions-list:not([mini])':
  'enter': 'intentions:confirm'
  'j': 'core:move-up'
  'k': 'core:move-down'

Note: This package does not work on older Atoms. You should install the latest version of Atom from: https://atom.io/

APIs

Intentions provides two kinds of APIs, there's Intentions List API that allows you to add items to intentions list. Here is what it looks like,

Intentions List API

The second type of API is highlight API. It allows packages to mark buffer ranges and do cool thing with them. It can be jump-to-declaration click, show type on mouse move and show color as underline. Here is what it looks like

You can find docs about both of these in Intentions Wiki

License

This package is licensed under the terms of MIT License, see the license file for more info.

intentions's People

Contributors

aminya avatar bennypowers avatar greenkeeper[bot] avatar greenkeeperio-bot avatar pfitzseb avatar steelbrain avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

intentions's Issues

Atom and Intentions version issue Installing/Uninstalling - Ubuntu 18.04

Lately I have been getting this error on startup Atom editor. (This issue maybe related to Ubuntu/Linux only)

screenshot_6
Linked Issue is closed: #64

When I try to uninstall/re-install the intentions package, I see this message in packages section of my editor.
It says: version 2.1.0 is not the latest version available for this package, but it’s the latest that is compatible with your version of Atom.
screenshot_7

But there is no improvement, even after that step.

I have installed latest versions of Atom editor through Ubuntu Software store and also through cloning Github repository: Hacking on Atom Core.
The problem is because I am unable to uninstall my current Atom editor, I am not able to access my new installations.
screenshot_9

Atom : 1.48.0
Electron: 5.0.13
Chrome : 73.0.3683.121
Node : 12.0.0
Ubuntu : 18.04

Uncaught Error: Cannot find module 'sb-event-kit'

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.17.1 x64
Electron: 1.3.15
OS: Unknown Windows version
Thrown From: intentions package 1.1.2

Stack Trace

Uncaught Error: Cannot find module 'sb-event-kit'

At module.js:457

Error: Cannot find module 'sb-event-kit'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (~/AppData/Local/atom/app-1.17.1/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (~/AppData/Local/atom/app-1.17.1/resources/app/src/module-cache.js:354:1)
    at Module.require (~/AppData/Local/atom/app-1.17.1/resources/app/static/index.js:40:43)
    at require (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:66:1)
    at /packages/intentions/node_modules/disposable-event/lib/index.js:3:19)
    at Module.get_Module._compile (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:106:1)
    at Object.value [as .js] (~/AppData/Local/atom/app-1.17.1/resources/app/src/compile-cache.js:230:1)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (~/AppData/Local/atom/app-1.17.1/resources/app/static/index.js:47:45)
    at require (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:66:1)
    at /packages/linter-ui-default/lib/editor/index.js:3:35)
    at Module.get_Module._compile (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:106:1)
    at Object.value [as .js] (~/AppData/Local/atom/app-1.17.1/resources/app/src/compile-cache.js:230:1)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (~/AppData/Local/atom/app-1.17.1/resources/app/static/index.js:47:45)
    at require (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:66:1)
    at /packages/linter-ui-default/lib/editors.js:3:43)
    at Module.get_Module._compile (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:106:1)
    at Object.value [as .js] (~/AppData/Local/atom/app-1.17.1/resources/app/src/compile-cache.js:230:1)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (~/AppData/Local/atom/app-1.17.1/resources/app/static/index.js:47:45)
    at require (~/AppData/Local/atom/app-1.17.1/resources/app/src/native-compile-cache.js:66:1)
    at LinterUI.observeShowDecorations (/packages/linter-ui-default/lib/main.js:51:19)

Commands

Non-Core Packages

angular-2-typeScript-snippets 0.6.3 
angularjs 0.4.0 
angularjs-helper 0.10.2 
atom-beautify 0.29.24 
atom-material-syntax 1.0.6 
atom-typescript 11.0.3 
busy-signal 1.4.1 
intentions 1.1.2 
linter 2.1.4 
linter-ui-default 1.6.0 

Failed to activate the intentions package

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.17.0-dev-6a76ef5dd x64
Electron: 1.6.4
OS: Mac OS X 10.12.3
Thrown From: intentions package 1.1.2

Stack Trace

Failed to activate the intentions package

At /Users/stellar/.atom/packages/intentions/lib/index.js: Buffer is not a constructor

TypeError: /Users/stellar/.atom/packages/intentions/lib/index.js: Buffer is not a constructor
    at Converter.toBase64 (/Applications/Atom.app/Contents/Resources/app/node_modules/convert-source-map/index.js:61:10)
    at Converter.toComment (/Applications/Atom.app/Contents/Resources/app/node_modules/convert-source-map/index.js:65:21)
    at File.generate (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/file/index.js:812:82)
    at File.transform (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/file/index.js:625:17)
    at /Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/pipeline.js:168:19
    at File.wrap (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/file/index.js:639:16)
    at Pipeline.transform (/Applications/Atom.app/Contents/Resources/app/node_modules/babel-core/lib/transformation/pipeline.js:165:17)
    at Object.exports.compile (/Applications/Atom.app/Contents/Resources/app/src/babel.js:70:1)
    at Object.compile (/Applications/Atom.app/Contents/Resources/app/src/package-transpilation-registry.js:68:1)
    at compileFileAtPath (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:97:1)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:229:1)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:56:1)
    at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:810:1)
    at Package.module.exports.Package.activateNow (/Applications/Atom.app/Contents/Resources/app/src/package.js:211:1)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:194:1
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:100:1)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:187:1
    at Package.module.exports.Package.activate (/Applications/Atom.app/Contents/Resources/app/src/package.js:184:1)
    at PackageManager.module.exports.PackageManager.activatePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:557:1)
    at /Applications/Atom.app/Contents/Resources/app/src/package-manager.js:538:1
    at Config.module.exports.Config.transactAsync (/Applications/Atom.app/Contents/Resources/app/src/config.js:346:1)
    at PackageManager.module.exports.PackageManager.activatePackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:533:1)
    at PackageManager.module.exports.PackageManager.activate (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:515:1)
    at /Applications/Atom.app/Contents/Resources/app/src/atom-environment.js:874:1

Commands

Non-Core Packages

busy-signal 1.3.0 
intentions 1.1.2 
lebab 0.10.0 
linter 2.1.2 
linter-eslint 8.1.4 
linter-ui-default 1.2.2 

It seems like intentions broke with linter 2.0

Since the new linter version yesterday intentions no longer shows me the intentions list, when pressing the shortcut.

I am using intentions together with linter-spell to get spell correction support.

Does anybody get the same bug?

Menu will break requiring keys to be held

If you press the keys bound to intentions:show, then while the menu is open press them again, the menu will disappear... and will require the keys to be held down to show (breaking the ability to use any actions).

Async support for intentions list

To be able to use this I think we need async support. It'd also be super-cool if it could support nested menus with an async hook on each level. I'm thinking

rename
add import ->
   (calls import suggestion async)
   import java.util.Thang
   import scala.Thang 

Scrolling doesn't work

As shown below, the tooltip is not automatically scrolling as before when the selected option is out of the displayed range. Mouse scroll doesn't work either since it scrolls the whole screen even if the cursor hovers the tooltip.

linter-ui-default-problem

Note also that if I scroll by clicking on the bar on the right, I have to hold the click and select the option with the keyboard at the same time, otherwise the tooltip disappears.

I use archlinux and atom 1.58.0. I removed my ~/.atom folder and reinstalled the relevant plugins but it doesn't solve the problem. Everything was alright some time ago. There is nothing specific to latex, but the problem may also come from linter-ui-default.

Unexpected token .

seeing error

Unexpected token .
Hide Stack Trace
/home/eve/.atom/packages/intentions/dist/index.js:1
(function (exports, require, module, __filename, __dirname, process, global, Buffer) { return function (exports, require, module, __filename, __dirname) { var e,t=require("atom").Disposable,n=require("assert"),i=(e=require("disposable-event"))&&e.__esModule?e.default:e;function s(e,t,n,i){Object.defineProperty(e,t,{get:n,set:i,enumerable:!0,configurable:!0})}s(module.exports,"consumeHighlightIntentions",(()=>Re)),s(module.exports,"activate",(()=>je)),s(module.exports,"deactivate",(()=>Fe)),s(module.exports,"consumeListIntentions",(()=>Ve));var o={};Object.defineProperty(o,"__esModule",{value:!0}),o.CompositeDisposable=o.Disposable=o.Emitter=void 0;var r={};Object.defineProperty(r,"__esModule",{value:!0}),r.default=void 0;var l=function(){function e(e,t){for(var n=0;n<t.length;n++){var i=t[n];i.enumerable=i.enumerable||!1,i.configurable=!0,"value"in i&&(i.writable=!0),Object.defineProperty(e,i.key,i)}}return function(t,n,i){return n&&e(t.prototype,n),i&&e(t
SyntaxError: Unexpected token .
    at new Script (vm.js:83:7)
    at NativeCompileCache.runInThisContext (/usr/share/atom/resources/app/static/<embedded>:11:146391)
    at Module.get_Module._compile (/usr/share/atom/resources/app/static/<embedded>:11:147275)
    at Object.value [as .js] (/usr/share/atom/resources/app/static/<embedded>:11:151046)
    at Module.load (internal/modules/cjs/loader.js:645:32)
    at Function.Module._load (internal/modules/cjs/loader.js:560:12)
    at Module.require (file:///usr/share/atom/resources/app.asar/static/index.js:72:46)
    at require (internal/modules/cjs/helpers.js:16:16)
    at customRequire (/usr/share/atom/resources/app/static/<embedded>:1:696928)
    at Package.requireMainModule (/usr/share/atom/resources/app/static/<embedded>:11:3578827)
    at /usr/share/atom/resources/app/static/<embedded>:11:3565367
    at Package.measure (/usr/share/atom/resources/app/static/<embedded>:11:3564167)
    at Package.load (/usr/share/atom/resources/app/static/<embedded>:11:3564940)
    at PackageManager.loadAvailablePackage (/usr/share/atom/resources/app/static/<embedded>:11:382096)
    at /usr/share/atom/resources/app/static/<embedded>:11:380519
    at Config.transact (/usr/share/atom/resources/app/static/<embedded>:11:332489)
    at PackageManager.loadPackages (/usr/share/atom/resources/app/static/<embedded>:11:380457)
    at /usr/share/atom/resources/app/static/<embedded>:1:717515
    at async Promise.all (index 0)
    at AtomEnvironment.startEditorWindow (/usr/share/atom/resources/app/static/<embedded>:1:719554)

same as closed issue #64

still an error even after doing

apm uninstall intentions
apm install intentions
atom --version
Atom    : 1.53.0
Electron: 6.1.12
Chrome  : 76.0.3809.146
Node    : 12.4.0

Thrown From: intentions package 2.1.0

seeing error on my Ubuntu 21.04 laptop but issue is orthogonal to the OS

Can't trigger intentions list

I've been attempting to use the "Fix linter issue" intention, but I can't seem to trigger the list on macOS using the default command ctrl+enter. At first I thought the new Git commands were interfering (committing is also done using ctrl+enter), but after setting a new shortcut in my keymap.cson (ctrl+alt+enter) the list still isn't triggered.

I've tried the behaviour in JavaScript (linter-eslint), PHP (linter-php) and SCSS files (linter-stylehint) containing errors, but the menu nevers shows. Not sure if every linter package has an autofix intention, but I was under the impression that eslint does. I'm using Atom 1.18.0 on macOS Sierra and the error console doesn't show any errors when attempting to trigger the intentions.

Uncaught TypeError: Illegal invocation

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.58.0 x64
Electron: 9.4.4
OS: Unknown Windows version
Thrown From: intentions package 2.1.1

Stack Trace

Uncaught TypeError: Illegal invocation

At C:\Users\thoma\.atom\packages\intentions\dist\index.js:1

TypeError: Illegal invocation
    at HTMLDocument.ke (/packages/intentions/dist/index.js:1:19315)

Commands

     -0:20.5.0 script:run (input.hidden-input)
  3x -0:10 omnisharp-atom:solution-status (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages

busy-signal 2.0.1 
intentions 2.1.1 
linter 3.4.0 
linter-ui-default 3.4.1 
omnisharp-atom 0.31.2 
script 3.32.2 

Keyboard interaction captured after selecting option

After selecting an option from the dropdown list with the keyboard, the up/down and return keys no longer function - it seems like the core movement keys aren't being restored on dismissal.

If the option is selected via clicking, or the popup is dismissed by clicking away, the keyboard navigation works as normal.

Reported on the PureScript plugin using linter nwolverson/atom-ide-purescript#168 - I've also reproduced with linter-eslint 8.2.1, intentions 1.1.5, atom 1.18.0 (OSX).

1.1.3 breaks contextual intentions

Hello

I noticed you introduced caching for the intentions list in 1.1.3. Caching is a neat thing, but it seems that this cache keeps the list in its entirety cached for the entire editor until it changes. This is a problem for me as my packages provide contextual intentions (i.e. what intentions are displayed depend on the cursor position). For example: you can only generate getters if you are in a class, you can only extract code into a method when you have a selection, you can only show documentation when the cursor is on a structural element, ...

With this change, the list is now generated once and then is the same everywhere until the editor is modified.

Is there perhaps an option I need to pass back or a flag I need to set in my provider to ensure the results can be dynamic?

Thanks!

Implement busy-status integration

Hello

I've recently begun requiring intentions for php-integrator-refactoring to allow the user to select contextual commands from the list. This works very well and I've now been wondering if it would be a good idea to have some kind of placeholder (i.e. "No intentions available") if none of the providers return any intentions (or some way of taking a look at and possibly updating the final combined list from all providers).

Thanks in advance

An in-range update of jasmine-fix is breaking the build 🚨

Version 1.1.0 of jasmine-fix just got published.

Branch Build failing 🚨
Dependency jasmine-fix
Current Version 1.0.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As jasmine-fix is β€œonly” a devDependency of this project it might not break production or downstream projects, but β€œonly” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ ci/circleci Your tests failed on CircleCI Details

Commits

The new version differs by 5 commits0.

  • 9ef86b1 1.1.0
  • c5e8938 :memo: Document change in CHANGELOG
  • 463023c :art: Simplify package and add polyfill for waitsForPromise
  • facc385 Merge pull request #1 from steelbrain/greenkeeper/initial
  • fed5dea docs(readme): add Greenkeeper badge

false

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

Using intentions as the code actions package?

I was thinking about using this package for our code actions. But the way decorations are handled causes issues such as #72.

What I want to suggest is to:

  • add a light bulb for the line where the user is (like Jetbrains or VSCode) instead of decorating all the available intensions in the whole editor

  • In case people want to see all the decorations when CTRL is held, we should switch to DisplayLayer instead of creating individual decorations for each. This would be much faster.

I am still confused about our solution for code actions, but it seems that the intentions package fits the problem better. πŸ€”

The alternative could be merging the code of the Intentions into Linter and retire Intentions. This would be the service API and how the actions are managed. Then we can use Linter-UI tooltips instead of the UI that intentions use. I prefer that we do not clutter the editor with code action decorations, so we need to adjust the UI of Linter-UI for this task.

Related: steelbrain/linter#1705

Keybinding on macOS doesn't trigger

The change in #87 made the keybinding's specificity for intentions:show lower than a core keybinding, so it's no longer triggered.

Screenshot:
keybinding-1

I've fixed this on my machine by adding atom-workspace to the selector (I'm not sure if there's a more appropriate fix though).

Screenshot with fix:
keybinding-2

The tests are failing in new Atom

I created #75 which bumps the dependencies, but the tests fail in the new Atom versions. The tests should be fixed

ProvidersHighlight
  trigger
    it works properly
      Expected promise to be resolved, but it was rejected with: Invalid Point: (NaN, 0) {  }
    it ignores previous result from executed twice instantly
      Expected promise to be resolved, but it was rejected with: Invalid Point: (NaN, 0) {  }
      Expected promise to be resolved, but it was rejected with: Invalid Point: (NaN, 0) {  }
    it does not enable it if providers return no results, including non-array ones
      Expected promise to be resolved, but it was rejected with: Invalid Point: (NaN, 0) {  }
    it emits an error if provider throws an error
      Expected 'Invalid Point: (NaN, 0)' to be 'test from provider'.
        Error: Expected 'Invalid Point: (NaN, 0)' to be 'test from provider'.
        at file:///C:/Users/aminy/Documents/GitHub/JavaScript/@atom-ide-community/intentions/spec/providers-highlight-spec.js:243:31
    it triggers providers based on scope
      Expected promise to be resolved, but it was rejected with: Invalid Point: (NaN, 0) {  }
  it automatically updates length of decoration everytime coordinates update
    Expected promise to be resolved, but it was rejected with: Invalid Point: (NaN, 0) {  }


Finished in 1.347 seconds
51 tests, 197 assertions, 7 failures, 0 skipped

Use Atom command listener

It seems that currently the command to open the intentions list (Alt+Enter on Windows) is implemented using a custom DOM event listener (due to an old Atom bug?).

Move back to the Atom command API so the command is shown in the settings.

Failed to load the intentions package

[Enter steps to reproduce:]

  1. ...
  2. ...

Atom: 1.17.2 x64
Electron: 1.3.15
OS: Mac OS X 10.12.5
Thrown From: intentions package 1.1.2

Stack Trace

Failed to load the intentions package

At Cannot find module 'sb-event-kit'

Error: Cannot find module 'sb-event-kit'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (/Applications/Atom.app/Contents/Resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.get_Module._resolveFilename (/Applications/Atom.app/Contents/Resources/app/src/module-cache.js:354:1)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:40:43)
    at require (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:66:1)
    at /packages/intentions/lib/main.js:13:19)
    at Module.get_Module._compile (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:106:1)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:230:1)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:47:45)
    at require (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:66:1)
    at /packages/intentions/lib/index.js:3:34)
    at Module.get_Module._compile (/Applications/Atom.app/Contents/Resources/app/src/native-compile-cache.js:106:1)
    at Object.value [as .js] (/Applications/Atom.app/Contents/Resources/app/src/compile-cache.js:230:1)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (Applications/Atom.app/Contents/Resources/app/static/index.js:47:45)
    at require (internal/module.js:20:19)
    at customRequire (/Applications/Atom.app/Contents/Resources/app/static/<embedded>:73:1)
    at Package.module.exports.Package.requireMainModule (/Applications/Atom.app/Contents/Resources/app/src/package.js:887:1)
    at /Applications/Atom.app/Contents/Resources/app/src/package.js:158:1
    at Package.module.exports.Package.measure (/Applications/Atom.app/Contents/Resources/app/src/package.js:99:1)
    at Package.module.exports.Package.load (/Applications/Atom.app/Contents/Resources/app/src/package.js:144:1)
    at PackageManager.module.exports.PackageManager.loadAvailablePackage (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:562:1)
    at /Applications/Atom.app/Contents/Resources/app/src/package-manager.js:476:1
    at Config.module.exports.Config.transact (/Applications/Atom.app/Contents/Resources/app/src/config.js:321:1)
    at PackageManager.module.exports.PackageManager.loadPackages (/Applications/Atom.app/Contents/Resources/app/src/package-manager.js:470:1)

Commands

Non-Core Packages

atom-beautify 0.29.26 
javascript-snippets 1.2.1 
react-snippets 0.7.4 
autocomplete-paths 1.0.5 
busy-signal 1.4.3 
emmet 2.4.3 
fast-eslint 3.13.0 
git-blame 1.1.1 
hyperclick 0.0.40 
intentions 1.1.2 
js-hyperclick 1.11.0 
last-cursor-position 0.9.2 
linter 2.1.4 
linter-ui-default 1.6.0 
minimap 4.28.2 
platformio-ide-terminal 2.5.1 
terminal-plus 0.14.5 

intentions highlights render outside of current editor pane

when using multiple panes (e.g. side-by-side), intention highlights also render on top of other panes

steps to reproduce

  • split the atom editor into multiple panes (preferably to the right)
  • open a file with long lines in one of the panes (preferably the left one)
  • make sure that some text is horizontally outside of the viewport
  • hold down the key to trigger intention highlights (default: ctrl)

expected result

  • intention highlights are only rendered within the current pane

actual result

  • intention highlights overflow the current pane and are rendered on top of others, even though the words they are highlighting are clipped
  • lines that are vertically out of the viewport are apparently mostly not affected

screenshots

atom_2018-02-24_12-42-13
atom_2018-02-24_12-45-34
atom_2018-02-24_12-44-47 (note how intentions highlights also render on top of the tabbar of the lower pane, however they don't render within the lower pane's editor)

I tested this issue with (everything up-to-date):

  • Windows 10
  • Atom 1.24.0
  • intentions 1.1.5
  • declarations 1.1.3
  • declarations-js 1.0.2
  • every other community atom package disabled

An in-range update of disposable-event is breaking the build 🚨

Version 1.0.3 of disposable-event just got published.

Branch Build failing 🚨
Dependency disposable-event
Current Version 1.0.2
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

disposable-event is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this πŸ’ͺ

Status Details
  • ❌ ci/circleci Your tests failed on CircleCI Details

Commits

The new version differs by 2 commits.

  • 2173c8c :arrow_up: Bump version to 1.0.3
  • 1266770 :no_entry: Disallow .flowconfig in npm

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

intentions:show triggers error

Hi,

I have this error both with atom 1.18.0 and 1.19.0-beta5 on linux.
I'm using linter-spell on a simple test .txt file.

When using alt+enter to run intentions:show, nothing happens and I get the following stack trace on the developers tools console:

main.js [sm]:34 Uncaught (in promise) TypeError: Cannot read property 'get' of undefined(…)

(anonymous function) @ main.js [sm]:34
step main.js:9(anonymous function) @ main.js:9
(anonymous function) @ main.js:9
(anonymous function) @ commands.js 
[sm]:219emit @ emitter.js:84
(anonymous function) @ commands.js [sm]:209
step @ commands.js:9
(anonymous function) @ commands.js:9
(anonymous function) @ commands.js:9
(anonymous function) @ commands.js [sm]:127
step @ commands.js:9
(anonymous function) @ commands.js:9
(anonymous function) @ commands.js:9
intentionsShow @ commands.js [sm]:40
module.exports.CommandRegistry.handleCommandEvent @ <embedded>:18901
(anonymous function) @ <embedded>:18639
module.exports.KeymapManager.dispatchCommandEvent @ <embedded>:66514
module.exports.KeymapManager.handleKeyboardEvent @ <embedded>:66305
module.exports.WindowEventHandler.handleDocumentKeyEvent @ <embedded>:15166
(anonymous function) @ <embedded>:15069

I attach a screenshot demonstrating the issue.

screenshot from 2017-07-26 19-57-19

What is going on ?

Thanks !

atom-ide-base disables intentions automatically

When I start atom, when I look in my packages, Intentions package is always disable even when i enable it and restart atom, it's again disable.

I tried to uninstall/install but no changes... Any idea ?

Uncaught TypeError: Cannot read property 'selected' of undefined

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.4.0
System: Mac OS X 10.11.4
Thrown From: intentions package, v0.1.4

Stack Trace

Uncaught TypeError: Cannot read property 'selected' of undefined

At /Users/nw/.atom/packages/intentions/lib/main.js:37

TypeError: Cannot read property 'selected' of undefined
    at /Users/nw/.atom/packages/intentions/lib/main.js:37:47
    at Function.module.exports.Emitter.simpleDispatch (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/lib/emitter.js:125:28)
    at Commands.confirmSelection (/Users/nw/.atom/packages/intentions/lib/commands.js:34:18)
    at atom-text-editor.intentionsConfirm (/Users/nw/.atom/packages/intentions/lib/commands.js:16:39)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:536:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:359:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:97:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -0:34.3.0 settings-view:open (atom-text-editor.editor.is-focused)
     -0:22.2.0 intentions:show (atom-text-editor.editor.is-focused)
     -0:19.7.0 grammar-selector:show (atom-text-editor.editor)
     -0:18.7.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:18.6.0 core:select-all (atom-text-editor.editor.mini.is-focused)
     -0:17.6.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -0:15.4.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:13.3.0 core:move-left (a.inline-block)
     -0:11.5.0 intentions:show (atom-text-editor.editor.is-focused)
     -0:02.9.0 core:move-down (atom-text-editor.editor.is-focused)
     -0:02.8.0 core:move-right (atom-text-editor.editor.is-focused)
     -0:02.4.0 intentions:show (atom-text-editor.editor.is-focused)
     -0:01.1.0 core:move-down (atom-text-editor.editor.is-focused.intentions-active)
     -0:00.6.0 intentions:confirm (atom-text-editor.editor.is-focused.intentions-active)

Config

{
  "core": {
    "closeEmptyWindows": false,
    "destroyEmptyPanes": false,
    "disabledPackages": [
      "background-tips",
      "vim-mode",
      "open-on-github"
    ],
    "themes": [
      "one-light-ui",
      "one-light-syntax"
    ]
  }
}

Installed Packages

# User
color-picker, v2.1.0
custom-title, v1.0.1
emmet, v2.4.0
file-icons, v1.6.14
highlight-selected, v0.11.1
intentions, v0.1.4
intentions-colorpicker, v0.1.0
language-babel, v2.12.1
linter, v1.11.3
pigments, v0.20.0
steel-flint, v0.0.0

# Dev
No dev packages

Submenu support for v2?

I was talking about intentions on the Slack channel and @steelbrain suggested I open a ticket for submenu support because I had a possible use case for it.

1 Attached is an example from ReSharper which puts common refactorings on the top level and uncommon (but still used) refactorings in a sub menu. This is useful since common ones are easier to access.

intentions submenu

2 I would also like to use it for spell-check or related program. Having the first 1-4 suggestions in the menu would be great with a sub menu for additional suggestions and places to put the "ignore" or "add to dictionary" options (which are plugin driven and there can be multiple entries).

3 I'm also trying to write a support page for writers. There are a lot of possible refactorings for English and I think having a sub menu would make it easier to organize some of them without having the VS menu overload.

vs menu

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.