stefanosaittamrf / eslint-mrf Goto Github PK

Rule

• no magic numbers

Discussion

it's pretty annoying, magic numbers should better be checked in the PRs
example

Proposed change

remove no-magic-numbers

does it make sense to you to sort the rules alphabetically?
I think it would make it easier to find/modify/remove and to follow along with the docs http://eslint.org/docs/rules/

Rule

• sort-imports

Discussion

The casing should be ignored, and maybe this rule could be removed, I personally prefer to sort the imports in the order that they are used.

Proposed change

  {
    "sort-imports": ["error", {"ignoreCase": false}]
  }

Reference

#4

Discussion

I think is better to change the extension from json to js in order to put comments in there and help us spot mistakes easly.

I think we should add a test files that cover all the rules, and run TravisCI on it in order to make this repo reliable as much as possible.

Rule

• comma-dange

Discussion

I personally hate to see the a comma after the last property of an object.

1. never seen it in any codebase in my life, even in marfeel
2. since now it's only required for objects, i find it inconsistent with arrays, and for objects/arrays with only one property/element it's awful { seh:'seh', }
3. no JSON compatible

Proposed change

  {
    "comma-dangle": "error"
  }

Discussion

I would like to remove the google-eslint-config dependency and do a plain files with rules, maybe later we can publish a linter that just extend this one on the project where we want to use it.

Rule

• YOUR_RULE

Discussion

Explaination of the issue. MAX 200 words.

Proposed change

  {
    "your_rule" : [2, {
      "prop": "true",
      "prop2": "true"
    }]
  }

Rule

• sort-imports

Discussion

It should be ignore case

Proposed change

  {
    "sort-imports" : [2, {
       "ignoreCase": true
    }]
  }

Rule

Discussion

adapt google rules

Proposed change

• no-cond-assign from off to ["error", "always"]
• no-irregular-whitespace --> remove for duplicate
• valid-jsdoc remove bc we do not use jsdoc
• no-extend-native from error to warn, as it's already redefined
• no-invalid-this remove
• no-unused-vars remove, e.g. unused arguments for widgets
• max-len redefined "max-len": [ "warn", { "code": 120, "tabWidth": 2, "ignoreComments": true, "ignoreTemplateLiterals": true, "ignoreUrls": true } ]

Rule

• require jsdoc

Discussion

the linter triggers an error if a class or function isn't jsdocumented.
since it's not in the line of the codebase it should be removed

Proposed change

remove

"require-jsdoc"

Rule

• YOUR_RULE

Discussion

Explaination of the issue. MAX 200 words.

Proposed change

  {
    "your_rule" : [2, {
      "prop": "true",
      "prop2": "true"
    }]
  }