steinz / lab-specimen-transport-system Goto Github PK

You can currently edit and delete things we want to be immutable.
We need to remove several edit and delete pages and add a "hide" action that 
marks items as deleted in the database but doesn't actually delete them for 
some models (ones with hidden fields in the uml class diagram / current 
db/schema.rb file).

We also need to make sure that these models attrbutes can't be changed by 
messing diretly with URL parameters, see 
http://guides.rubyonrails.org/v2.3.8/security.html#countermeasures

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

CC just failed to update because of a merge update again.

Can we just run fixit.sh as part of builder.sh?
Might need to take it out of the repo so that it doesn't conflict itself...

Does the course staff need to have access to our basecamp tasks?
I think they might want to be able to audit this...

We need an automated way to deploy the web app to a shared AWS instance.

The process should be documented on the SetupAWS or a RunAWS wiki page.

The process should ensure that the pushed changes pass all tests before 
permanently applying them.
Alternatively, we could require devs to run the tests themselves via Rake 
before pushing anything, but the automated solution would be more convenient.

Define MVC/Rails controllers in the Controllers wiki page.

Use cases and UI prototypes/flow diagrams should expose all of the actions the 
controllers should handle.

ref: http://guides.rubyonrails.org/action_controller_overview.html

Pages are linked together correctly on the side menu, now I need to make the 
data show up correctly.  This will be my task for the majority of Beta Release

From Zach's email:

Subject + I noticed a few random things, many of which you probably
already know about.

The outgoing item view should maybe include some estimate of when the
next courier is expected to arrive to pick things up - "Next scheduled
pick up: 5/4 at 1:45 pm"

I think the menu would look nicer if it was "chunked" into a few
categories - something like

UW SPS (user's location - maybe all locations for supervisors)
  Incoming
  Outgoing
Items
  Add New
  Lookup
  Check In
Accounts
  Locations
  Users
  Couriers
Tasks
  Routes
  Checklists
Edit Account

Maybe this should be exposed as submenus (press Items to expand
indented section, etc).
I also think the new pages should just be accessible from the index
page instead of having their own button - e.g. New User should be a
button on the User page - otherwise the menu is going to get pretty
cluttered.

We might want to genericize our item views somehow as well - incoming
and outgoing lists are great, but we might also want to see recently
delivered or other locations (for supervisors) which doesn't seem to
fit anywhere naturally right now.

I also think the entire page should have a maximum width enforced. So
if I maximie the window on a widescreen monitor their are margins on
the left and right borders instead of the middle tables in the page
just getting really stretched out - everything stays more readable in
my opinion if the width is capped.

I think we should move the logout button to the upper right of the window - 
most sites put it up there, so I think it makes for a bit easier UX.

Define models, relationships, and attributes in the Modeling wiki page.
Geneate a useful graphical representation.
Get reviewed by entire back-end team.

Forgot password, register (shouldn't have these links, since don't know if we 
want to support them now).  Make sure all links work!

Text on the login page needs to be updated (blah blah blah)

Like we discussed in the meeting, we need an integration test for Beta Release

What steps will reproduce the problem?

In the ruby console, create an Item - "Item.new.save"
Then do "Item.first.attributes"

What is the expected output? What do you see instead?

This should return a list of Attributes like Attribute.first.item does.
The problem is a namespace collison - .attributes is already a method.
The easiest fix will be to change "Attribute" back to "Label" or something else.

Incoming and Outgoing items pages are the most important, but users might also 
want to see other slices (recently picked-up / dropped-off for example). 
Multiple locations also need to be exposed to supervisors.

The item views need to be redesigned slightly to provide these additional 
options.

Editing locations (in editing locations, etc.)

\n newlines showing up (from fixture locations)
formatting nil

Also figure out why the text area for the address is messed up when displaying 
after save:
1. Enter address in a new location
2. Save location
3. Go back to editing the location, will see that the formatting has extra 
spaces in the text area

What steps will reproduce the problem?
1. Look at the repository.

What is the expected output? What do you see instead?
Lots of code. No code.

Lookup something that doesn't exist, needs an error message

We need to know how to display routes in the web app using the Google Maps API. 
This is a stretch feature.

Plausability and procedure notes should be added to the wiki.

We have the ability to 'delete' individual items, but this deletes them from 
the database.  We don't want that.  We also don't want to mark them as hidden 
(that will be for anonymous items that are in a container)

We should have a 'deleted' column specifying if the item has been deleted

Should have a checkbox on the new item page for choosing if you want to print 
the item (should be turned on by default).

After create item, will redirect to a page to print the item barcode(s) (plural 
if have items in the bag), based on that checkbox.

This page should look something like the following:
---------------------------------------------------
Print your Barcodes                   print all
---------------------------------------------------
Box FrthwD24RJ:                        || ||| ||| ||||
Frozen Green                           print

  Items inside Box FrthwD24RJ
  Bag DEJ325jskjD:                     || ||| ||| ||||
  Frozen Blue                          print

    Items inside Bag DEJ325jskjD
    Specimen SdgJLF143j:               || ||| ||| ||||
    Frozen Red                         print

  Specimen DEJ325jskjD:                || ||| ||| ||||
  Frozen Blue                          print

---------------------------------------------------
                                      print all
---------------------------------------------------

FEATURE REQUEST:

Need to have a controller to be able to centralize all layouts into a common 
html (we had talked about this Thursday)

http://getsatisfaction.com/

js can go in the layout

The two recurrence_rules models could be combined into a single polymorphic 
model as described here:

http://guides.rubyonrails.org/v2.3.8/association_basics.html#polymorphic-associa
tions

This will make applying the recurrence rules (generating route and checklist 
instances) more generic and therefore less repetitive to code. It also suggests 
a Task abstraction, where Checklists and Routes are both instances of tasks. 
Expanding on this idea would allow for a more configurable "A Courier's Day" 
page, where Checklist Items and Stops could be more easily mixed.

The controllers, tests, views, routes, and helpers will need to be "combined" 
as well (delete one, fix field names in other).

If you go to check in an item and search for an item through the lookup bar 
(the same bar that is on the lookup page), it should redirect you to the page 
for checking in that item.

Right now, it only goes to the lookup page (should be able to pass in what page 
you go to)

I also think the entire page should have a maximum width enforced. So if I 
maximize the window on a widescreen monitor their are margins on the left and 
right borders instead of the middle tables in the page just getting really 
stretched out - everything stays more readable in my opinion if the width is 
capped.

In our model meeting, we had discussed changing the user database setup (it 
doesn't look like these have been changed yet)

  * contact_info: should be separated into email and phone_number
  * permission_level: should have an enum (of sorts) to easily identify which permission levels mean what (admin, user, courier are the 3 I can think of right now)

Since we're using the CheckIns to display a history of the item, we will need 
to store more information.  I was thinking an enum representing :delivered, 
:picked_up, etc. (any statuses we see fit to add).

When this is implemented, reassign this back to me and I'll update the 
item_information partial to show the history accurately ("User A (picked 
up/delivered) item (at/to) Location F")

The menu is currently overwhelming - it could use some chunking.
Zach's preliminary suggestion:

UW SPS
  Incoming
  Outgoing
Items
  Add New
  Lookup
  Check In
Accounts
  Locations
  Users
  Couriers
Tasks
  Routes
  Checklists
Edit Account

And maybe for supervisors,

Locations
  UW SPS
    Incoming
    Outgoing
  Harborview
  Children's

instead of just the UW SPS chunk.

I also think the new pages should just be accessible from the index page 
instead of having their own button - e.g. New User should be a button on the 
User page - otherwise the menu is going to get pretty cluttered. 

From assignment 5 dev doc:

"The source code should contain comments. At a minimum, every file should have 
a comment describing its purpose and, if appropriate or not obvious, how it 
fits into your overall design. Also, every procedure is required to have at 
least a one-sentence comment describing what it does — or more if 
appropriate..."

This sounds overly verbose for the Rails app - conventions dictate where most 
of the code goes and what it does. We should ask if we can skip documenting 
things that should be obvious given the Rails conventions.

We should also write a quick script to prepend licensing and any comment 
template we do decide we need to file headers as comments. The script should 
write comments in different ways depending on the file type (=begin for Ruby, 
<!-- for HTML, etc). It would also be cool if it asked you from command line to 
fill in easy required info - primary owner, quick summary, etc. Ideally, it 
should also be callable as a Rake task.

It would also be good if the comments it spit out were compatible with rdoc, 
but I'm not sure if this will work well with Rails.

Views only display the div their content is in. The head (containing css and 
scripts) and rest of the body are missing (header and sidebar).

We need to know how to generate and print barcodes.

This includes a few steps:
1) Generating an unused identifier
2) Generating a barcode (image) from that identifier

Model associations can't be tested until the models have test fixtures.
We only need one or two test objects for each model.
The id references all need to be valid.
This is also a great way to get more familiar with the data model.

You need to be able to see this.

- Admin should see everything (in side menu)
- Supervisor should see everything except Location (only admin can add 
locations)
- Staff should only see Incoming, Outgoing, Lookup, Add New, Checkin, and Edit 
Account
- Client should only see Outgoing, Lookup, Add New, Checkin, and Edit Account
- Courier should only see Lookup and Edit Account

This should be supported in the menu (based on what to display) and on ALL 
pages (if a user without the permissions tries to access the page, then 
displays an error message (use render)

Try to abstract this out as much as possible

Clients should be able to see when the next pick up is scheduled at their 
location, e.g. "Next scheduled pick up: 5/4 at 1:45 pm" at the top of the 
outgoing page.

Feel free to switch this back to me (Zach) once you need the dynamic data.

Use complex forms, which is linked 
[http://guides.rubyonrails.org/v2.3.8/form_helpers.html#building-complex-forms 
here] 
http://guides.rubyonrails.org/v2.3.8/form_helpers.html#building-complex-forms 
to do it.

What steps will reproduce the problem?
1. http://localhost:3000/locations

What is the expected output? What do you see instead?
Expected: New lines without seeing the newline character
Actual: See the newline character

Routes are not functional

Right now, the header for the content needs to be manually added (page name, 
logout button, etc.)

A partial for this header that contains the page name, current user logged in, 
and logout button needs to be created.

Reprint link doesn't work for items page.

This is pending getting barcodes to work to print.

individual box
"items inside bag" -> "items inside box"

should be dynamically generated based on item_type

Needed for Android to get at things in a RESTful way.

Need the correct routes hooked up and controllers implemented to satisfy their 
requests.

Nothing is linked yet. Figure out how to tie it in with the back end.

What steps will reproduce the problem?
1. Login to an existing user account (that you created yourself)
2. Reset the database (with, for example, db:fixtures:load).  Leave the browser 
open
3. Try reloading the page (it will break)

We should be resetting the session if we can't find the user from the session 
variable.  This way, we avoid breaking (this can happen if a user is signed in 
and an administrator deletes the account while that user is signed in)

This will be a backend and a website change (for the pages we already 
accomodate for "No Type").

All items should have an item type.

In order to do this, we will need to support the ability to add a type on the 
item creation page (that is hidden)...this will be post-beta

Test fixtures need to set User.password for the hashes/salts to be generated 
correctly.

These bypass the validation, so will need to be updated to make sure loading 
them doesn't break parts of the website that rely on those validations.

Things I can think of right now:
- Item.item_type
- User.permission_level


Add to this list if you see more

The way I included the HAML gem in environment.rb is deprecated.

Bundler doesn't work on Windows installs if Bitnami is installed in "Program 
Files" or on any other path including a space.

We will have to include rmagik and barby/barcode-generator soon - we need some 
stable way to tell Rails about and install dependencies.

Exiting the barcode scanning view on the android application will occasionally 
cause the application to crash. I suspect this is due to autofocus/image 
processing algorithms continuing to be scheduled by the timer used in the 
activity. Resolving this will be one of my highest priority tasks for the beta 
release.

Items added to the system need a barcode generated for them.

What needs to be decided:

1) Format of barcode. Options are: BARCODE_EAN, BARCODE_UPC, BARCODE_ISBN, 
BARCODE_128B, BARCODE_128C, BARCODE_128, BARCODE_128RAW, BARCODE_39, 
BARCODE_I25, BARCODE_CBR, BARCODE_MSI, BARCODE_PLS, BARCODE_93, BARCODE_ANY, 
and BARCODE_NO_CHECKSUM. 

2) Format of generated image of barcode (png, gif, etc...).