Giter VIP home page Giter VIP logo

jpasskit's People

Contributors

cmspray avatar codacy-badger avatar dbeard avatar dependabot-support avatar derekfangming avatar drallgood avatar joconagy avatar jozsef-nagy-epam avatar ramyhardan avatar roamingthings avatar sbuljat avatar stepio avatar woolfel avatar zouabimourad avatar

Watchers

 avatar  avatar

jpasskit's Issues

Improve API to support reusing the same ObjectMapper

Now there is only one constructor available - with ObjectMapper. But actually you cannot pass existing immutable instance, as additional configurations are applied in constructor:

        jsonObjectMapper.setSerializationInclusion(Include.NON_NULL);
        jsonObjectMapper.addMixIn(Object.class, ValidateFilterMixIn.class);
        jsonObjectMapper.addMixIn(PKPass.class, PkPassFilterMixIn.class);
        jsonObjectMapper.addMixIn(PKBarcode.class, BarcodeFilterMixIn.class);
        jsonObjectMapper.addMixIn(Charset.class, CharsetFilterMixIn.class);

So if you'd like to use the existing object mapper (as API owner suggests), it's state is altered, which is not very good.

Use java 7 in signing package

  • use java 7 approach for resource closing & exception handling
  • remove code duplication
  • stop using deprecated methods
  • update tests
  • fix warnings in pom.xml
  • support relative path for template resources
  • support non-unix file separators in manifest files

Update setter for "suppressStripShine" to set "null" instead of "false"

According to the Passbook documentation:
https://developer.apple.com/library/ios/documentation/UserExperience/Reference/PassKit_Bundle/Chapters/TopLevel.html#//apple_ref/doc/uid/TP40012026-CH2-SW2

Key name Type Description
suppressStripShine Boolean Optional. If true, the strip image is displayed without a shine effect. The default value prior to iOS 7.0 is false. In iOS 7.0, a shine effect is never applied, and this key is deprecated.

As key is deprecated, uprated setter to enable partial cleansing for this deprecated parameter.

Ignore eclipse project files

Eclipse project (internal) files should not be included into repository: different versions of eclipse update them differently. That's why ".classpath" file (for example) is always modified in my repository, which complicates commits.

Make "passThatWasSet" accessible

Update PKPass class, add getPassThatWasSet function:

    public PKGenericPass getPassThatWasSet() {
        return passThatWasSet;
    }

This is required to simplify implementation of type-independent processing methods for passes.

Fix maven build descriptor

Fix various issues:

  • add ability to build in Mac OS X - skip calling "gpg" for this OS;
  • fix javadoc generating in JDK 1.7 - skip argument "-Xdoclint:none";
  • minor cleanup.

Linking Android Apps to a Pass

New feature from PassWallet Developer Guide v0.7

As of v1.31 of PassWallet, support for linking a pass to an Android app was added.
In order to link the pass, add the following section to the pass.json as a top level field:

"associatedApps" : [
    {
        "title":"PassWallet - Passbook + NFC",
        "idGooglePlay":"com.attidomobile.passwallet",
        "idAmazon":"com.attidomobile.passwallet"
    }
]

One or more apps can be associated with the pass.

Add support of other forms of RGB triplets

Update function convertStringToColor to support reading Color from six-digit (hex triplet) and three-digit (shorthand) hexadecimal forms.
Provides better flexibility for importing of passes.

Default value for "voided" should be "null" instead of "false" to make it optional

According to the Passbook documentation:
https://developer.apple.com/library/ios/documentation/UserExperience/Reference/PassKit_Bundle/Chapters/TopLevel.html#//apple_ref/doc/uid/TP40012026-CH2-SW2

Key name Type Description
voided Boolean Optional. Indicates that the pass is void—for example, a one time use coupon that has been redeemed. The default value is false. Available in iOS 7.0.

But if "false" value is set from Java code (as it's done now), than this key is always included (with "false" by default). So it becomes mandatory instead of optional, what is incorrect and useless.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.