stevekinney / firesale-tutorial Goto Github PK

In the step where we replace the console.log in openFile function of the main process with the following:
mainWindow.webContents.send('file-opened', file, content);
Then writing renderer code

The md file I picked to display in the console was not sent to the renderer process until I decide to put the line above inside this

mainWindow.webContents.on('did-finish-load', () => {
  mainWindow.webContents.send('file-opened', file, content);
});

according to webContents API documentation

did-finish-load is emitted when the navigation is done.

Can't say for sure why, but in case anyone runs into this issue, you need to wait until the mainWindow.webContents finished loading.

From its doc at: https://github.com/electron/electron/blob/master/docs/api/web-contents.md

  win.webContents.on('did-finish-load', () => {
    win.webContents.send('ping', 'whoooooooh!');
  });

The send function only works without the 'did finish load' callback later on in the tutorial, when it comes to the open file dialog fired by the on click event.

Can anyone explain, why?

I am noticing that when I run the app via

npm start
I am able to access the remote module from renderer, but when i run it as
electron .
I see this error on the console.
Uncaught Error: Cannot find module 'remote'
Would you know why