Examples crash when trying to open in Safari about simple-server HOT 12 CLOSED

Time to write a test to reproduce it, so I can have a go fixing it! 😄

from simple-server.

It maybe that you've used one or more previous HTTP servers on127.0.0.1, and your cookie cache for this address contains a lot of cookies (well, enough to push the request size over 512 bytes). AFAIK, all these previous cookies (which haven't expired) will be sent to the example here.

That is amazing! Like a lightbulb. Great job debugging!

This means this is a duplicate of #19

from simple-server.

@booyaa Your stack trace output gives it away. The current request handling code is a little naive and each request cannot exceed 512 bytes, including headers. If it does, then it unwrap()s a Partial content response result, which panics.

To demonstrate, you can replicate this using CURL...

curl --header "X-SOME-HEADER: gWbWykBHgObDHriErqIKRBqebBekBpHsqUJqQcDtDctkaeeFBwNelgvzigaEkUPKAfcnYGhgbzDOvGumdewDzCqOantKfsvaZuggZaTjqtUzOXHVYwsSjknsMTPyWzvzGrNdRExaSIjiehYvuSAMdOMpwakKlKxCPwYAyAlpqXpoiargAZnAVIRfUJVpBnotmQRsDtAZoFfSXyRvqGQluzWWVTOCItNSCqBPUfFQGoxoSewvuSStgDtCYfCnFCFNczEwGkLiPidmrpbQDPuIvopUbxvojuUrBfgjoTwslrnDIJGAWIMoMkOQzYdzxVaCDfSQlmHwkpdkxByhuWXmuLgAzgJvIuhAMMlXaHIMcGmymGCxsgUjUkzKwrzafCsfkSivOXIzNSmTGhdgBufQTqdlRbuDBZijZCOXmpwhKFzlaSleXzgMaEpDiEjxzPUwIOwhomPDVSzaTqEZCpivNWyfunffMNUaLdkxLudYEpSgwTOGUipJjvXbocrKbfFG" http://127.0.0.1:7878

The fact that noone seems to have this problem points to your individual browser configuration. It maybe that you've used one or more previous HTTP servers on127.0.0.1, and your cookie cache for this address contains a lot of cookies (well, enough to push the request size over 512 bytes). AFAIK, all these previous cookies (which haven't expired) will be sent to the example here. Try opening the example in Private Mode to see if that solves it.

from simple-server.

Wow thanks @gmbeard switched to private and it didn't crash the server example! Time to go clear out the cookies for 127.0.0.1. Nice detective work!

from simple-server.

hey @booyaa ! thanks for filing. i just tried to reproduce this on my machine (same except i'm not on High Sierra) and could not. i'm gonna tag this with needs reproduction and see if we cant get someone else to reproduce it so we can get to fixing it!

if you happen to figure it out please follow up on this thread!

from simple-server.

Can't repro on High Sierra:

• At commit: 66d8b4d
• Safari Version 11.0 (13604.1.38.1.6)
• rustc 1.21.0 (3b72af97e 2017-10-09), stable-x86_64-apple-darwin
• System Version: macOS 10.13 (17A365)
• Kernel Version: Darwin 17.0.0

from simple-server.

Can't repro here either.

• Commit 66d8b4d
• rustc 1.21.0 (3b72af97e 2017-10-09)
• Safari Version 11.0 (13604.1.38.1.6)
• Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64 x86_64

from simple-server.

It looks like @urschrei and @aaroncm are using a newer version of Safari. @booyaa maybe if you update Safari it'll solve your problem?

from simple-server.

Hello all,

I'm running the following versions of things, and can report no crash here. 😢

from simple-server.

I can't repro on High Sierra either.

Commit 66d8b4d
rustc 1.21.0
Safari Version 11.0 (13604.1.38.1.6)
Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64 x86_64

from simple-server.

Cant reproduce either.

• rustc 1.21.0 (3b72af97e 2017-10-09)
• Safari Version 11.0 (13604.1.38.1.6)
• Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64

from simple-server.

This is definitely looking like a fault with this Safari build (12604.1.38.1.7).

Thanks everyone!

If anyone has a suggestion how I might catch what Safari is trying to send in the request to simple_server, would greatly appreciate it.

from simple-server.