stevenlimhw / ped Goto Github PK

• UG said that at least one of the optional fields must be included, but it doesn't work with tag
• cannot clear tag and edit phone number even though number is valid and message is wrong



add n/John Doe p/98765432 e/johnd@gmail a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 16-10-22 t/Severe

is accepted, even without the .com at the end

The command

find t

should not show John Doe and Betsy Crowe (only Tom pitt) should be shown. Unless, this might be intended behaviour as the UG states that find accepts a variety of inputs (not only name). This could be made clearer.

It is too easy to accidentally clear the whole data from the app by simply using the command.

Perhaps, additional confirmation can be done before clearing as this is a high-risk operation.

Some ideas include:

• Pop-up messages can be added
• Add more flags that are difficult to type to prevent accidental clears

Some examples of the commands ran:

add n/John Doe4 p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 29-02-22 t/Severe

add n/John Doe5 p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 30-02-22 t/Severe

add n/John Doe6 p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 31-02-22 t/Severe

For all of the commands above, 28 Feb 22 is recorded instead instead of showing an error message.

Example Image



The user may accidentally input capitalized word instead.

add n/John Do p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine t/Severe

versus

add n/John Do p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine t/severe



add n/John Doe p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 30-02-20 t/Severe

30 Feb 2020 should not be valid although 2020 is a leap year.

Output shows 29 Feb 2020 instead of an error message.





Only a single format is allowed for date inputs. Some users may want to use a whitespace or a forward-slash instead of a hyphen.

After calling

add n/Jane Doe p/91234567 e/[email protected] a/20 Anderson Road, block 123, #1-01

then calling

delete 1

according to the format under Quick Start



The entry is not deleted.





Example

add n/Tom pitt p/9090-4213 e/[email protected] a/Bourvard street blk 341 #4-17 d/Moniter blood pressure | 23-10-22 1200 | 3 days

add n/Tom pitt p/909 e/[email protected] a/Bourvard street blk 341 #4-17 d/Moniter blood pressure | 23-10-22 1200 | 3 days

909 is not a valid phone number

add n/John Doe3 p/98765432 e/[email protected] a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 31-04-22 t/Severe

30 April 2022 is recorded instead of showing an error message, even though 31 April 2022 is not a valid date.



The command

add n/John Doe p/98765432 e/johnd@fjkldjfkldsjflsdlfsjd a/John street, block 123, #1-01 d/Administer 3ml of example medicine | 16-10-22 t/Severe

should not be accepted since it is invalid.

Perhaps, there can be a check on valid strings after the "@" symbol?