dimdoors's People
Forkers
deathrat keenerb overminddl1 senseikiwi agaricusb carsonoid nicolaosgreene cannibalvox clienthax bahzur evilliveshere ashleylov3 kubius edgaradr223 darkpixel797dimdoors's Issues
crashes when server stopping at times
Looks to be caused by a NPE in my chunk loader
Some vanilla blocks dont rotate properly
Anvils, fences, vines, chests, and fence gates
Fabric of Reality cannot be mined by a Digital Miner in Silk Touch Mode
You told me to put it here so I did. :)
config for Corium
i cant find the Block id for Corium it seems to be id 900 so i cant change it.
i hope you guys can fix it i love your mod. :)
DD dimensions not reloading upon reboot
ChickenChunks normally reloads the dimensions/chunks that it is suppose to keep loaded upon reboot. However, this does not happen with DD dimensions. You have to visit the dimension first before the chunk stays loaded for the remainder of that game session.
cannot assign negative/reduced weight
Severe world leaking.
On infinite cycle:
2013-06-11 06:15:28 [FINE] [ForgeModLoader] The world 34df2786 (world) may have leaked: seen 1060 times.
2013-06-11 06:15:28 [FINE] [ForgeModLoader] The world 32601e72 (world) may have leaked: seen 1060 times.
2013-06-11 06:16:18 [FINE] [ForgeModLoader] The world 34df2786 (world) may have leaked: seen 1065 times.
2013-06-11 06:16:18 [FINE] [ForgeModLoader] The world 32601e72 (world) may have leaked: seen 1065 times.
Eventually server does bog down to a point where people can no longer connect or stay connected. Hasn't actually crashed the server yet, but it does seem to but it down eventually. For me, users started having issues around 20K leaks, and I could no longer connect. Did not wait for server to crash completely, I just restarted it.
Code Reorganization Needed
There are several portions of Dimensional Dungeons that are interwoven in ways that make the mod more complex. For instance, we have very large methods for importing and exporting schematics, and the export code is mixed in with other dungeon handling functions. For the sake of maintenance and sanity, we really should separate portions of the code into coherent units. Importing and exporting should be done in the same class or separate classes for each one, without any additional code involved. That is, we give these classes information on where to operate and they operate on a region of the world, and that's it. Within that code, all of the repetition needs to be refactored out. All of the loops that search for a particular block type and then perform an operation on them could be generalized.
This also touches upon rotations. Those need to be reimplemented in a way that is both efficient and manageable. I'll see what I can do about that - we can extract all the information gathered on the various metadata values by brute-forcing over all metadata values or parsing them from the code.
Code that is heavily dependent upon Minecraft's version or Forge's version must also be isolated so that maintaining support for 1.5.2 is trivial. Instead of relying on performing reverts, we should have separate copies of version-dependent classes for each MC version. Then our updates would consist of changing the common code between both versions and committing once. This might be easier said than done.
Note that in general, this is more of a reminder to myself of all the things that need to be fixed. Having a checklist, even in the form of issues, provides guidance.
Client side console spam
seems like it happens when interacting with dim doors. placing them, entering them and breaking them.
I am on a customer technic server with this mod.
Forge 952 1.6
Console Spam with Rift Remover
If you create a lot of rifts together and apply the Rift Remover, the console gets spammed with "Tried to update client link data & failed!"
Item ID Registration is Bugged
The way that item IDs are registered has a flaw due to the wonky way that Forge handles item IDs. This means that when we generate stacks of items using our item ID, Forge is unable to retrieve the underlying item for us, and it will either return null or a reference to another item that could even be from another mod. While this needs to be fixed, it must be done with care to avoid breaking existing saves. I can handle this, I think.
Commands are terribly clunky, and break if not entered properly
Blacklist usage is unclear
The blacklist file in world/DimensionalDoors/Data has no clear syntax on how it is to be used.
Rift Issue with Non-North-Oriented Dungeons
If you export a room that wasn't oriented North, then creating a rift to that room afterward will cause the rift to appear beside the player instead of inside the player's head. I also believe that when you attach doors to these rifts, sometimes to teleport into the room in strange positions or off the proper orientation. I haven't tried reproducing this recently, so I'm not sure if it was fixed after schematic rotation was fully rewritten. The room and entry door always appear to be facing the right direction.
How to reproduce: Create a room with dd-create that has its entrance not oriented toward the North. Export the room and use dd-rift to create a rift into it. Notice that the rift will appear beside you, not in the block where your head is as should occur.
Load Built-In Dungeons as Custom Dungeons
Just noting that we need to change Dimensional Doors so that dungeons that are stored as part of the mod can be loaded using the same code as custom dungeons, taking advantage of the tagging system. That would eliminate the need to hardcode the loading of each dungeon.
NullPointerException in yCoordHelper
DarianStephens reported the following crash on our MC forums thread. He said it happens when he enters Limbo. I believe it might be a bug in our code:
java.lang.NullPointerException
at StevenDimDoors.mod_pocketDim.helpers.yCoordHelper.getFirstUncovered(yCoordHelper.java:42)
at StevenDimDoors.mod_pocketDim.CommonTickHandler.placeMonolithsInLimbo(CommonTickHandler.java:180)
at StevenDimDoors.mod_pocketDim.CommonTickHandler.tickEnd(CommonTickHandler.java:58)
at cpw.mods.fml.common.SingleIntervalHandler.tickEnd(SingleIntervalHandler.java:34)
at cpw.mods.fml.common.FMLCommonHandler.tickEnd(FMLCommonHandler.java:141)
at cpw.mods.fml.common.FMLCommonHandler.onPostServerTick(FMLCommonHandler.java:274)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:608)
at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:171)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:470)
at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573)
New dimHelper crashes
I would like to report a possible bug with DimDoors new dimHelper update that on exiting of SMP and SSP it crashes the client.
Will double check with other mods on the server/client to see if theirs a conflict
Stacktrace:
at StevenDimDoors.mod_pocketDim.dimHelper.save(dimHelper.java:1050)
at StevenDimDoors.mod_pocketDim.ConnectionHandler.connectionClosed(ConnectionHandler.java:47)
at cpw.mods.fml.common.network.NetworkRegistry.connectionClosed(NetworkRegistry.java:219)
at cpw.mods.fml.common.network.FMLNetworkHandler.onConnectionClosed(FMLNetworkHandler.java:330)
at net.minecraft.client.multiplayer.NetClientHandler.func_72546_b(NetClientHandler.java:808)
at net.minecraft.client.multiplayer.WorldClient.func_72882_A(WorldClient.java:287)
at net.minecraft.client.gui.GuiIngameMenu.func_73875_a(SourceFile:46)
at net.minecraft.client.gui.GuiScreen.func_73864_a(SourceFile:72)
at net.minecraft.client.gui.GuiScreen.func_73867_d(SourceFile:127)
at net.minecraft.client.gui.GuiScreen.func_73862_m(SourceFile:111)
Wooden Dim Doors Break Spontaneously
I've confirmed that several players, including myself, have seen wooden dim doors break randomly without any external cause. The doors break and drop a regular wooden door and a rift appears. I think that in every case, the rift appears immediately once the door breaks. This happened to me while working with dungeons using dd-create and dd-rift, but other players have reported that it can also happen inside regular dungeons.
How to reproduce: Spawn a dungeon with dd-rift. I saw this happen while in lockingExit, for instance. The room was oriented North at the time. Then just wait for a while and keep watching the door. It should break off eventually.
Dungeon Clipping
Portions of dungeons are not copied into the world when the dungeons are above or below height bounds. That means the player is sometimes teleported into a dungeon that has been cut off, potentially dropping the player into the void immediately or exposing large amounts of redstone and items that were not intended for the player. At the very least, it just ruins the dungeon.
We need to add checks to either reset the height of the entrance to an appropriate value for the room that the player is entering, or we need to limit the rooms that can be generated to only those that would fit in our bounds. The first approach seems like a better idea. The second approach would be complicated. Even though it would have the consequence that dungeons wouldn't correspond exactly in terms of entrance and exit heights, this would only occur around the top and bottom of the map, which is logical - you simply CAN'T go higher or lower around those bounds.
Localization support
I would translate the mod into the German language if it was added.
logging in to a server throws tons of exceptions
only happens after a logout without turning off client
This mod is too creepy now.
Minecraft crashes after entering the nether
I'm playing the 1.0.1 version of Hexxit. Already updated your mod, but doesn't helped.
Found a nether portal created by a meteor crash. After using it, the minecraft crashed before showing the nether. Now it crashes everytime I loads the savegame.
Crash log below
Minecraft has crashed!
Minecraft has stopped running because it encountered a problem; Unexpected error
A full error report has been saved to C:\Technic\data\hexxit\crash-reports\crash-2013-07-07_23.06.24-client.txt - Please include a copy of that file (Not this screen!) if you report this crash to anyone; without it, they will not be able to help fix the crash :(
--- BEGIN ERROR REPORT bd6bdeeb --------
Full report at:
C:\Technic\data\hexxit\crash-reports\crash-2013-07-07_23.06.24-client.txt
Please show that file to Mojang, NOT just this screen!
Generated 07/07/13 23:06
-- System Details --
Details:
Minecraft Version: 1.5.2
Operating System: Windows 7 (amd64) version 6.1
Java Version: 1.7.0_25, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 108699968 bytes (103 MB) / 749142016 bytes (714 MB) up to 1908932608 bytes (1820 MB)
JVM Flags: 2 total; -Xmx2048m -XX:MaxPermSize=256m
AABB Pool Size: 0 (0 bytes; 0 MB) allocated, 0 (0 bytes; 0 MB) used
Suspicious classes: FML and Forge are installed
IntCache: cache: 0, tcache: 0, allocated: 3, tallocated: 63
FML: MCP v7.51 FML v5.2.23.737 Minecraft Forge 7.8.1.737 Optifine OptiFine_1.5.2_HD_U_D5 63 mods loaded, 63 mods active
mcp{7.51} Minecraft Coder Pack Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
FML{5.2.23.737} Forge Mod Loader Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Forge{7.8.1.737} Minecraft Forge Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CodeChickenCore{0.8.7} CodeChicken Core Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CoFHFramework{1.5.2.4} CoFH Framework Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ImmibisMicroblocks{55.0.1} Immibis's Microblocks Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
NotEnoughItems{1.5.2.28} Not Enough Items Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
mod_bspkrsCore{v2.07(1.5.2)} bspkrsCore Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
TreeCapitator{Forge 1.5.2.r01} TreeCapitator Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CoFHCore{1.5.2.4} CoFHCore Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CoFHWorld{1.5.2.4} CoFHWorld Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
CustomLAN{2.2} Custom LAN Mod Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ImmibisMicroblocksInstallCheck{55.0.1} Immibis's Microblocks (Check for incorrect installation) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
DamageIndicatorsMod{2.7.0.1} [Damage Indicators](1.5.2 DamageIndicators v2.7.0.1.zip) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
AsgardShield_Core{2.0.4} AsgardShield Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ASAddon_Hallowed{2.0.0} AS Addon- Hallowed Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
HarkenScythe_Core{2.1.6} HarkenScythe Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ASAddon_HarkenScythe{2.0.0} AS Addon- HarkenScythe Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ASAddon_NetherEnder{2.0.0} AS Addon- Nether-Ender Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ASAddon_ColorAPI{1.0.0} ASAddon_ColorAPI Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
BetterStorage{0.6.2.23} BetterStorage Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
mod_ArmorBarMod{0.7.1} Armor Bar Mod Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Artifice{1.5.2R1.1.1} Artifice Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ArtificeCompat|Chisel{1.5.2R1.1.1} Artifice Compat: Chisel Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ArtificeCompat|EE3{1.5.2R1.1.1} Artifice Compat: EE3 Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ArtificeCompat|MFR{1.5.2R1.1.1} Artifice Compat: MFR Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ArtificeCompat|Vanilla{1.5.2R1.1.1} Artifice Compat: Vanilla Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Backpack{1.9.11} Backpack Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
mod_BackTools{1.5.2v1} mod_BackTools Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
BattleTowers{1.3.4} Battle Towers Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
BetterDungeons{1.8} Better dungeons Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
BiblioCraft{1.3.1} BiblioCraft Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
mod_BuffBarMod{0.7.1} Buff Bar Mod Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
DimDoors{1.5.2R1.4.0RC1} Dimensional Doors Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
eplus{1.15} Enchanting Plus Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ExtrabiomesXL{3.13.4} ExtrabiomesXL Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
hexxitgear{1.5.2R1.0} Hexxit Gear Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ImmibisCore{55.1.2} Immibis Core Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
InfernalMobs{1.3.1} Infernal Mobs Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
inventorytweaks{1.54b} Inventory Tweaks Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
MapWriter{2.0} MapWriter Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Meteors{2.10.2} [Falling Meteors](Meteors Mod V2.10.2.zip) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
More Bows{1.5_v1} [More Bows mod](More bows 1.5.2_2 Forge.jar) Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Natura{1.5.1_2.1} Natura Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
Natura|CompatMineFactoryReloaded{0.1} Natura compat: MFR Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
NEIPlugins{1.0.9.3} NEI Plugins Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
LegendGear{1.5.2} LegendGear Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ObsidiPlates{1.5.0} Obsidian Pressure Plates Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
OffLawn{1.0} offLawn Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ProjectZulu|Core{1.0.3.8} Project Zulu Core Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ProjectZulu|Blocks{1.0.3.8} Project Zulu Block and Items Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ProjectZulu|Dungeon{1.0.3.8} Project Zulu Mobs Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ProjectZulu|Mobs{1.0.3.8} Project Zulu Mobs Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
ProjectZulu|World{1.0.3.8} Project Zulu World Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
xreliquary{1.5.2} Xeno's Reliquary Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
rftl{1.0} RottenFleshToLeather Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
AS_Ruins{10.3} Ruins Spawning System Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
SoulShards{1.0.16} Soul Shards Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
TConstruct{1.5.1_1.3.4.3} Tinkers' Construct Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
TConstruct|CompatMineFactoryReloaded{0.1} TConstruct Compat: MFR Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
TwilightForest{1.18.1} The Twilight Forest Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
WildCaves3{0.4.2} Wild Caves 3 Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
chococraft{2.8.6} Torojima's ChocoCraft Unloaded->Constructed->Pre-initialized->Initialized->Post-initialized->Available->Available->Available->Available
LWJGL: 2.4.2
OpenGL: GeForce GTX 660/PCIe/SSE2 GL version 4.3.0, NVIDIA Corporation
Is Modded: Definitely; Client brand changed to 'fml,forge'
Type: Client (map_client.txt)
Texture Pack: Default
Profiler Position: N/A (disabled)
Vec3 Pool Size: ERROR NullPointerException: null
java.lang.NullPointerException
at StevenDimDoors.mod_pocketDim.DimData.printAllLinkData(DimData.java:264)
at StevenDimDoors.mod_pocketDim.EventHookContainer.onWorldLoad(EventHookContainer.java:83)
at net.minecraftforge.event.ASMEventHandler_24_EventHookContainer_onWorldLoad_Load.invoke(.dynamic)
at net.minecraftforge.event.ASMEventHandler.invoke(ASMEventHandler.java:39)
at net.minecraftforge.event.EventBus.post(EventBus.java:108)
at net.minecraft.client.multiplayer.WorldClient.(WorldClient.java:69)
at net.minecraft.client.multiplayer.NetClientHandler.func_72455_a(NetClientHandler.java:333)
at net.minecraft.network.packet.Packet1Login.func_73279_a(Packet1Login.java:119)
at net.minecraft.network.MemoryConnection.func_74428_b(MemoryConnection.java:89)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1899)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:835)
at net.minecraft.client.Minecraft.run(Minecraft.java:760)
at java.lang.Thread.run(Unknown Source)
--- END ERROR REPORT f88cd394 ----------
Transdimensional Trapdoors cause Problems
I don't have much time to go into detail about this so I'll have to make it quick. Our code seems to be reliant on door-type blocks and doesn't support trapdoors properly. For instance, placing a Dimensional Door, then breaking it and attaching a Transdimensional Trapdoor causes an exception and the door slams shut. I'm fairly certain that other issues would arise if that code could continue running. At some point, traverseDimDoor() got a parameter "Block door". A lot of code seems to assume that block is going to be a normal door and not a trapdoor.
I also noticed that some function in PocketBuilder requires us to sent it a Block that implements IDimDoor. Maybe we should consider changing the parameter to BaseDimDoor? Or at least BlockDoor. Especially if we're going to use ItemDoor to place the block.
Latest jenkin build introduces massive lag!
With the latest Jenkin build I'm having massive lags pretty much at a constanst rate every 10 seconds or so for about 3-4 seconds.
The whole game becomes unresponsive for 3-4 seconds. I can move around, break blocks but after 3-4 seconds everything "unfreezes" and mobs move, and blocks that I broke rebreak.
Night Vision Does Not Work
Upon having the night vision effect on, the screen turns black.
Dimdoors dims save too often
I keep seeing my server console saving about every other min even though no one is currently using the doors or on the server.
Forge 952 1.6
no server impact at this moment.
dd-rift command is broken
RiftRegenerator NPEs sometimes
Keeping inventory on death in pocket dim doesnt re-equip armor
No way to control if DD items appear in chests
SecretRooms and DimensionalDoors incompatibility
Error log: https://docs.google.com/file/d/0BxiZLvZs3AuQX2FJS3RZYU8xSTA/edit?usp=sharing (updated)
Issue is happening when SecretRooms block and DimDoors block are in the same chunk.
Results in chunk save failed, chunk invalidated and fully reset.
The most interesting are two exceptions at the bottom of log, lines 3012 and 3045
EDIT:
Sorry, my fault. SecretRooms was fixed in AbrarSyed/SecretRoomsMod-forge@8d7e5381 to not do such bad things :)
handle orphaned dungeon types
ocassionally getting the 'something broke' dungeon
Crashing when entering Dimension while having ArsMagica enabled!
ArsMagica and Dimensional Door aparently don't like each other. You'll either crash or hang and dowloading world screen.
Potential performance issue with Golden Doors
Using a mod called Opis, i discovered that the golden doors were using quite a bit of the tick time relative to the other TEs on the server.
Must Implement Dirty Flag
We need to implement a dirty flag because saving the data for all dimensions has the potential to be a heavy operation. That might explain people's suspicions that having a lot of pocket dimensions causes servers to slow down noticeably.
It might also be a good idea to add time constraints to our saving code so that it runs under a time limit. We can have a forced full save at the end when the server shuts down.
Saving and Loading Need Review
I looked over the code for saving and loading. Although it handles dimension dependencies properly, the design for the loading portion needs attention. PocketManager and DDSaveHandler are tightly coupled. The goal was to leave the task of loading the packed data to DDSaveHandler and PocketManager then takes that data. Instead, function calls weave back and forth between the two classes. This also makes it impossible to determine whether a dimension should be saved immediately after being loaded, so we're forced to write all dimensions to disk to be on the safe side.
Oh, and strangely enough, if loading fails, we don't do anything! But we print out a little message if loading succeeds. <_<
Dungeons ignore TileEntity inventories
Crash issue
The issue stuff: http://pastebin.com/GHgEQXEA
And dont try to pass it along to chicken bones. It's your issue for not safety checking. If you want to argue over if it's yours or chicken bones, go ahead. I hope you aren't that kind of person. I dont mean to be a jackass but modders always seem to try to pass it along and I want to prevent that.
Also: This is NOT MY ISSUE. I am reporting it for the forums thread linked in the pastenbin.
Rift spread not correctly regulated
Need to give it a hard limit- Just count up towards the parent rift and count
client still crashing inside of Dim door when relogging crash log attached
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] java.lang.IllegalArgumentException: Could not get provider type for dimension 2, does not exist
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraftforge.common.DimensionManager.getProviderType(DimensionManager.java:157)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraftforge.common.DimensionManager.createProviderFor(DimensionManager.java:311)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.world.WorldProvider.func_76570_a(WorldProvider.java:209)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.multiplayer.WorldClient.(WorldClient.java:62)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.multiplayer.NetClientHandler.func_72455_a(NetClientHandler.java:349)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.network.packet.Packet1Login.func_73279_a(Packet1Login.java:119)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.network.TcpConnection.func_74428_b(TcpConnection.java:462)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.multiplayer.NetClientHandler.func_72551_d(NetClientHandler.java:281)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.multiplayer.GuiConnecting.func_73876_c(GuiConnecting.java:51)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1580)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:910)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:838)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.client.main.Main.main(SourceFile:101)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at java.lang.reflect.Method.invoke(Unknown Source)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.launchwrapper.Launch.launch(Launch.java:131)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT] at net.minecraft.launchwrapper.Launch.main(Launch.java:27)
[05:11:23 INFO]: Client> 2013-12-05 05:11:23 [INFO] [STDOUT]
make rifts eat layer by layer
monolith causes client lag when it looks at a player
Client crashing when connnecting to server after client restart when player had logged out inside a pocket dim
When I attempt to connect after logging out inside a pocket dim, my client crashes as it is unable to find the correct dimension provider for the given dimension, it does not appear to be getting it from the server.
If I modify my player.dat to get out of the dim, it works just fine, and the dim is not deleted, just the client crashes. I will take a look into the source and see if i can find an idea
Server: MCPC+ (Build 97) (gson added to classpath)
Mod Version: Reports as 1.5.2R1.4.1RC1 but labeled as 2.1.0 beta
Crash Report Follows:
---- Minecraft Crash Report ----
// I bet Cylons wouldn't have this problem.
Time: 11/8/13 9:00 PM
Description: Ticking screen
java.lang.IllegalArgumentException: Could not get provider type for dimension 4, does not exist
at net.minecraftforge.common.DimensionManager.getProviderType(DimensionManager.java:157)
at net.minecraftforge.common.DimensionManager.createProviderFor(DimensionManager.java:311)
at net.minecraft.world.WorldProvider.func_76570_a(WorldProvider.java:209)
at net.minecraft.client.multiplayer.WorldClient.<init>(WorldClient.java:62)
at net.minecraft.client.multiplayer.NetClientHandler.func_72455_a(NetClientHandler.java:349)
at net.minecraft.network.packet.Packet1Login.func_73279_a(Packet1Login.java:119)
at net.minecraft.network.TcpConnection.func_74428_b(TcpConnection.java:462)
at net.minecraft.client.multiplayer.NetClientHandler.func_72551_d(NetClientHandler.java:281)
at net.minecraft.client.multiplayer.GuiConnecting.func_73876_c(GuiConnecting.java:51)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1578)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:908)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:836)
at net.minecraft.client.main.Main.main(SourceFile:101)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:57)
at net.minecraft.launchwrapper.Launch.main(Launch.java:18)
A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------
-- Head --
Stacktrace:
at net.minecraftforge.common.DimensionManager.getProviderType(DimensionManager.java:157)
at net.minecraftforge.common.DimensionManager.createProviderFor(DimensionManager.java:311)
at net.minecraft.world.WorldProvider.func_76570_a(WorldProvider.java:209)
at net.minecraft.client.multiplayer.WorldClient.<init>(WorldClient.java:62)
at net.minecraft.client.multiplayer.NetClientHandler.func_72455_a(NetClientHandler.java:349)
at net.minecraft.network.packet.Packet1Login.func_73279_a(Packet1Login.java:119)
at net.minecraft.network.TcpConnection.func_74428_b(TcpConnection.java:462)
at net.minecraft.client.multiplayer.NetClientHandler.func_72551_d(NetClientHandler.java:281)
at net.minecraft.client.multiplayer.GuiConnecting.func_73876_c(GuiConnecting.java:51)
-- Affected screen --
Details:
Screen name: net.minecraft.client.multiplayer.GuiConnecting
Stacktrace:
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1578)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:908)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:836)
at net.minecraft.client.main.Main.main(SourceFile:101)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:57)
at net.minecraft.launchwrapper.Launch.main(Launch.java:18)
[[snip]]
Ninja Semicolon in EventHookContainer
Found this semicolon while checking through our recent changes: https://github.com/StevenRS11/DimDoors/blob/master/src/main/java/StevenDimDoors/mod_pocketDim/EventHookContainer.java#L78
It's old, though I'm not sure how old. I don't want to just erase it out of concern of the impact that it could have. That music code has been causing crashes for some users and I honestly have no idea how it works. I patched it once to prevent a crash that someone reported, but that's it. Please sort out if that code works right.
Crash upon entering server (build 196)
When I try to login to a server, the server's getting this error:
2013-07-31 13:56:33 [INFO] [STDERR] Cannot Hotload Dim: Could not get provider type for dimension 29, does not exist
2013-07-31 13:56:33 [INFO] [Minecraft-Server] iconmaster5326[/74.71.171.202:51700] logged in with entity id 171 at (234.9608089712607, 64.0, -25.44471983402036)
2013-07-31 13:56:33 [INFO] [STDERR] Cannot Hotload Dim: Could not get provider type for dimension 29, does not exist
2013-07-31 13:56:33 [INFO] [Minecraft-Server] Disconnecting iconmaster5326 [/74.71.171.202:51700]: Internal server error
2013-07-31 13:56:33 [SEVERE] [ForgeModLoader] Error handling login related packet - connection from iconmaster5326 [/74.71.171.202:51700] refused
java.lang.NullPointerException
at net.minecraft.server.management.ServerConfigurationManager.func_72355_a(ServerConfigurationManager.java:120)
at net.minecraft.network.NetLoginHandler.completeConnection(NetLoginHandler.java:194)
at cpw.mods.fml.common.network.FMLNetworkHandler.handleClientConnection(FMLNetworkHandler.java:166)
at cpw.mods.fml.common.network.FMLNetworkHandler.onConnectionReceivedFromClient(FMLNetworkHandler.java:120)
at net.minecraft.network.NetLoginHandler.func_72529_d(NetLoginHandler.java:178)
at net.minecraft.network.NetLoginHandler.func_72532_c(NetLoginHandler.java:71)
at net.minecraft.server.ServerListenThread.func_71766_a(ServerListenThread.java:55)
at net.minecraft.server.dedicated.DedicatedServerListenThread.func_71747_b(SourceFile:29)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:677)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:275)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:573)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:470)
at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573)
2013-07-31 13:56:33 [WARNING] [Minecraft-Server] Failed to handle packet for iconmaster5326 [/74.71.171.202:51700]: java.lang.NullPointerException
java.lang.NullPointerException
at net.minecraft.server.management.ServerConfigurationManager.func_72355_a(ServerConfigurationManager.java:120)
at net.minecraft.network.NetLoginHandler.completeConnection(NetLoginHandler.java:194)
at cpw.mods.fml.common.network.FMLNetworkHandler.handleClientConnection(FMLNetworkHandler.java:166)
at cpw.mods.fml.common.network.FMLNetworkHandler.onConnectionReceivedFromClient(FMLNetworkHandler.java:120)
at net.minecraft.network.NetLoginHandler.func_72529_d(NetLoginHandler.java:178)
at net.minecraft.network.NetLoginHandler.func_72532_c(NetLoginHandler.java:71)
at net.minecraft.server.ServerListenThread.func_71766_a(ServerListenThread.java:55)
at net.minecraft.server.dedicated.DedicatedServerListenThread.func_71747_b(SourceFile:29)
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:677)
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:275)
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:573)
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:470)
at net.minecraft.server.ThreadMinecraftServer.run(SourceFile:573)
I've recently moved some files between me and the server. I hope my stuff's not gone; my main base was in a pocket dimension...
Server Crash on WorldGen (Build #293)
Receiving a repeatable server crash, in two different forms, caused by a NPE in StevenDimDoors.mod_pocketDim.world.gateways.BaseGateway.generate().
Crash logs are as follows:
Crash 1) http://pastebin.com/c4iVKHi6
Crash 2) http://pastebin.com/3PqijgAZ
SchematicLoader Exports Frustration
SchematicLoader causes me enormous frustration whenever I look at it and keeps me from wanting to further the development of Dimensional Doors. The following related issues remain:
- Why do the standard rotation formulas not apply to orienting rooms toward the East or West? We currently have those formulas swapped. One theory is that schematics are stored reflected relative to their original orientation.
- Some dungeons still don't load properly. We suspect it's because their schematics don't follow the usual reference orientation (enter facing North), but it's unclear if that's really the cause.
- Entrance-relative rotations don't work. This might be caused by the workaround we used for [1].
Pocket dimensions still not updating client correctly on servers when logging in.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.