stevensacks / react-smart-scroll Goto Github PK

This looks like a nice project and I'm trying it out to replace react-window in an app!

But I think I found a problem:

If data contains, for example, 1 item on the first render and then gets a bunch of more items later an undefined ref is passed to useComponentRect and it crashes when getting current from undefined.

Looks like it works on the first render since the ref list is initialized to the number of items in data (in ReactSmartScroll). But if more items are added to data then ReactSmartScrollRow receives an undefined rowRef until the useEffect is triggered that creates it and adds it to the list.

If the number of items in data is static then everything works.

Quick sandbox: https://codesandbox.io/s/react-smart-scroll-demo-veice
Click on the row to trigger adding of item and crash.

Happy to do a PR if wanted, but haven't had time to dig that deep into the code yet.

First of all, thank you, nice project.

Is there a way to retain scroll position when re-rendered (e.g. if I need to add/remove element is into/from data array)?