Comments (14)
stonith404
commented on May 24, 2024
Hey thanks for your enhancement. I don't really a reason for this feature because a reverse proxy would easily do this job. You just could spin up a reverse proxy container. Can I ask why you don't want to use a reverse proxy?
from pingvin-share.
woreibi
commented on May 24, 2024
Hi,
I was thinking to have full encryption end to end. With reverse proxy only one leg of communication is encrypted.
What is the name and location for server.js or node.js for frontend where it can reference https and cert keys to use?
Thank you,
from pingvin-share.
stonith404
commented on May 24, 2024
Sorry I don't know anything about SSL directly with Node.js, I'm not even sure if this is possible.
Additionally using SSL directly hasn't any advantages, or has it?
But you can easily enable SSL with a reverse proxy: https://domysee.com/blogposts/reverse-proxy-nginx-docker-compose
I personally use Nginx Proxy Manager, this is a reverse proxy with a GUI.
from pingvin-share.
woreibi
commented on May 24, 2024
Hi,
In order to enable SSL on node.js there is few lines of code that can be added. Below is an example of what node.js file would have:
https://nodejs.org/en/knowledge/HTTP/servers/how-to-create-a-HTTPS-server/
I was not able to find your node.js file to see if I can modify it and didn't know if you named it something else. If you let me know what is file name and it's location I can give it a try and modify the file.
Benefit to this is data communication is encrypted also internally while using a reverse proxy on second leg of communication between proxy and container.
If you would share the file name and location inside container that would be great.
Appreciate your great work on this.
Thank you
from pingvin-share.
stonith404
commented on May 24, 2024
There are plenty node.js files. For the frontend they are placed in the /frontend/src folder. The frontend uses nextjs btw.
from pingvin-share.
stevenengland
commented on May 24, 2024
+1 for https
I would love to be able to spin up this container with TLS support.
from pingvin-share.
stevenengland
commented on May 24, 2024
Additionally using SSL directly hasn't any advantages, or has it?
There are advantages. Encryption and possibly trust in the internal network. "Zero Trust".
from pingvin-share.
woreibi
commented on May 24, 2024
Hi Steven,
Main advantage is encryption of communication all through out if using a reverse proxy or browsing application directly. In my personal opinion any docker application should have flexibility to run on http or https with environment variables that allow users to configure what port you want it to listen to and allow you also to define SSL cert to use but that adds dev time to get that done. Iām not a dev person but I do tinker around and sometimes I can make the container work with https if it was not designed by creator to work with https and sometimes configuration is not very clear and Iām not successful.
In this instance I have not been successful so far but I have not tried again after my last communication with creator about path to NextJS config file.
Thanks
from pingvin-share.
stonith404
commented on May 24, 2024
I've never set up SSL directly with NextJS. If someone knows how to setup https directly with NextJS, feel free to create a PR :)
from pingvin-share.
woreibi
commented on May 24, 2024
Hi,
I tried yesterday to implement https on Nodejs webserver to practice and was able to get it done. It needs few lines of code.
I'm not sure if Nextjs follow same guide lines in code for https as Nodejs but this container didn't have a clear cut config file that I can locate. There is some many .is file in it and very difficult to know where is the actual config file where http and port are declared. If we can find that file I can try to add code to it.
Do you exactly where and what is the file name?
Last path I got from feedback was not correct...
Thank you,
Wissam
from pingvin-share.
stonith404
commented on May 24, 2024
I think NextJS creates the http server automatically in the background. But there is a way to create a custom web server with NextJS, but never used it before.
from pingvin-share.
woreibi
commented on May 24, 2024
I would love to help but without knowing where the config file is, it will be hard. There Will be a line of code to create http server and declare port it is listening on, if we can locate that file then it will become easier to troubleshoot.
Digging into this container it seemed to have so many .js files it would take a lot of time to dig through them.
I'm not sure if this container was copied from another project but I would think you would know where the main config file is since you are the owner of project.
Either way, I gave it a shot and it didn't work...I tried on another container that was done in Nodejs and dev owner didn't do https but I edited the file and added the code and was able to get that other project container working on https...so it should not be too different in this project either as long as main config file can be located...
I think this is the end of this open issue on my end. Without main file I can't do much.
Thanks everyone for your responses. I appreciate it.
Wissam
from pingvin-share.
stonith404
commented on May 24, 2024
@woreibi Thanks for your tries :) Sorry but I really don't know what you mean with a config file. There is a nextjs config file, but related to nodejs and nextjs there isn't any other config file.
As a work around, you could add nginx to the docker compose stack. With this solution the data is only not encrypted in the docker network. I understand this is not the solution you want, but it's pretty secure. The only way a "hacker" could read the traffic, is when he has access to the docker container and when he has access to the docker container, he easily could read the database.
from pingvin-share.
woreibi
commented on May 24, 2024
No worries. I have not tried Nextjs as a plain web server as a test that I can do and try to enable https but I'll look into that to see if it is different from Nodejs.
Thank you for the feedback.
Wissam
from pingvin-share.
Related Issues (20)
- š Feature: Requesting that the chunk file size be a configurable option HOT 8
- š Bug Report: Warning: 'xx' is defined but never used. no-unused-vars HOT 1
- ā Question: "next start" does not work with "output: standalone" configuration. Use "node .next/standalone/server.js" instead? HOT 2
- š Language request: Hungarian HOT 1
- ā Question: Is it possible to use MariaDB as Database? HOT 1
- ā Question: Uncaught Error: Minified React error #425 HOT 5
- š Feature: Upload IP Restrictions HOT 2
- ā Question: Configure Authelia HOT 4
- ā Question: Updating past docker image 1.22.1 HOT 6
- š Bug Report: Share and reverse share emails not working HOT 7
- After Update not running HOT 2
- š Feature: Default share expiration configurable in administration
- ā Question: HOT 2
- š Feature: Decouple "shares" from a reverse share (allow for shares created under a reverse share to be deleted individually by an admin) HOT 1
- ā Question: Is there a Discord server? HOT 6
- š Feature: Make "Name" a universal thing HOT 1
- š Language request: <Korean> HOT 1
- š Bug Report: 500 (Internal Server Error) when using the "Name" field HOT 17
- š Feature: Admin Share Management page enhancement
- ā Question: Email / Webhook notification on share update HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pingvin-share.