stormherz / atom-incsearch Goto Github PK

In incsearch/styles/incsearch.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor .incsearch-highlight .region, atom-text-editor::shadow .incsearch-highlight .region => atom-text-editor .incsearch-highlight .region, atom-text-editor.editor .incsearch-highlight .region

• atom-text-editor .incsearch-current .region, atom-text-editor::shadow .incsearch-current .region => atom-text-editor .incsearch-current .region, atom-text-editor.editor .incsearch-current .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

It would be great if Ctrl + I would move to the next match, if a search is already started. IMHO that makes the usage so much easier and faster than with separate key bindings.

I have added the following keybindings into my custom config, and this really makes using your package great:

'.platform-win32 .incsearch, .platform-linux .incsearch':
  'ctrl-i': 'incsearch:goto:next-match'
  'shift-ctrl-i': 'incsearch:goto:prev-match'

'.platform-darwin .incsearch':
  'cmd-i': 'incsearch:goto:next-match'
  'shift-cmd-i': 'incsearch:goto:prev-match'

In sublime, when the user presses shift-cmd-I the incremental search looks for previous matches. Currently with atom-incsearch to look for previous matches the user has to first press cmd-I, type their search, then press shift-cmd-I. Is it possible to add a setting to press shift-cmd-I to toggle reverse-search mode?

In incsearch\styles\incsearch.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor .incsearch-highlight .region, atom-text-editor::shadow .incsearch-highlight .region => atom-text-editor .incsearch-highlight .region, atom-text-editor.editor .incsearch-highlight .region

• atom-text-editor .incsearch-current .region, atom-text-editor::shadow .incsearch-current .region => atom-text-editor .incsearch-current .region, atom-text-editor.editor .incsearch-current .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

Repro steps:

1. apm install api-docs
2. Open any buffer, select a keyword (e.g. undefined), Ctrl+Shift+P, Api Docs: Search Under Cursor. An HTML doc view pane opens.
3. Focus the doc pane, Ctrl+Shift+P, incsearch:toggle.
4. Unhandled exception.

Atom Version: 1.12.7
Electron Version: 1.3.13
System: Ubuntu 15.10
Thrown From: incsearch package, v0.3.3

Stack Trace

Uncaught TypeError: Cannot read property 'onDidDestroy' of undefined

At /home/ulidtko/.atom/packages/incsearch/lib/incsearch.coffee:138

TypeError: Cannot read property 'onDidDestroy' of undefined
    at Object.show (/home/ulidtko/.atom/packages/incsearch/lib/incsearch.coffee:138:11)
    at atom-workspace.subscriptions.add.atom.commands.add.incsearch:toggle (/home/ulidtko/.atom/packages/incsearch/lib/incsearch.coffee:108:10)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app.asar/src/command-registry.js:259:29)
    at /usr/share/atom/resources/app.asar/src/command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:587:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/usr/share/atom/resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:382:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (/usr/share/atom/resources/app.asar/src/window-event-handler.js:106:36)
    at HTMLDocument.<anonymous> (/usr/share/atom/resources/app.asar/src/window-event-handler.js:3:59)