storybook-eol / storybook-addon-a11y Goto Github PK

Since storybook changed its libraries names,
A replace of lib names is required:
@kadira/storybook -> @storybook/react
@kadira/storybook-addons -> @storybook/addons

The a11y checks currently cause the viewport to be scrolled. There's an option to disable that check, but there's no way to configure that for the addon. Could you please expose a way to pass the aXe options through?

On windows platforms, the axe-core keeps trying to change the system npm modules:

npm ERR! at destStatted (C:\Program Files\nodejs\node_modules\npm\lib\install\action\finalize.js:25:7)
npm ERR! at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\polyfills.js:264:29
npm ERR! at FSReqWrap.oncomplete (fs.js:123:15)

which, by default, requires Administrator privileges. Is this needed or is there another way around it?

Got errors when adding checkA11y to one of my stories. Looks like you've already fixed the entry point, but not released it yet. Could you do a quick release for that fix?

hey,
I have tried install and use v3 following the instructions, but the addon isn't showing at all.
It's also not working on npm 'Try it out'

I know axe-core has different sets of rules it uses to test accessibility issues which can be determined programmatically.

I'm curious which ones storybook-addon-a11y, I'm guessing it uses the entire set?

cc/ @ndelangen

Hello,

Using a11y addon with info addon causes a violation as it tries to validate the color contrast of the show info toggle.

See attached image:

Is there a work around for this?

Thanks,
Rob

I'm not sure if this package is still maintained, Do you need help?

I'm happy to integrate this into the storybook monorepo if you'd like?

There's a 3.0.0 release coming, and I'd like to make sure addons are maintained, we're willing to help where we can!

Can you join us in the storybook slack?
https://storybooks-slackin.herokuapp.com/

That way we can keep you updated on the upcoming 3.0.0 release!

❤️ storybook team

We have a project we are using storyshots with storybook-addon-a11y. While we can run storybook in the browser without issue, when we run the tests based on the storyshots, we are getting multiple Invariant Violation: getNodeFromInstance: Invalid argument. errors.

Doing a quick google search on this error message led me to facebook/react#8324

It makes me think the use of findDomNode here is what is causing compatibility issues with storyshots.

Using decorator addA11y, it seems to interfere with our component styles.

Below shows the initial render, where the Designer name is not displayed:

I couldn't upload GIF here so here is a link on imgur:
Toggling height corrects the view to be what is expected

Not entirely sure whats happening however, this is the view when we disable .addDecorator(checkA11y)

This is the expected view.

any ideas?