Giter VIP home page Giter VIP logo

Comments (3)

Gongreg avatar Gongreg commented on August 29, 2024 1

Hey.

This issue has to be on your side, storybook doesn't deal with networking on any way, all it does it binds itself to 7007 port on your machine.

So you have to make sure that your machine allows connections to the port 7007 (it depends on the os/firewall/other things so I cannot really help you there).

Good luck!

from react-native.

robert-nash avatar robert-nash commented on August 29, 2024 1

@Gongreg
This seems like the same problem as discussed in storybookjs/storybook#6674.

I think there is more to this than just the networking setup. It seems to me that if no host is specified then the server defaults to listening on localhost

.option('-h, --host <host>', 'host to listen on', 'localhost')
As I understand it, in general binding to localhost means that requests will be accepted which are sent to specifically localhost. This is why a request to your local ip (in this issue 192.168.190.232) will not work if the server has bound to localhost.

storybookjs/storybook#6674 (comment) describes how binding to the specific address (i.e. 192.168.190.232) will accept request to that address or how binding to 0.0.0.0 accepts requests on any address including localhost and the local ip address.

Further investigation shows that the cli has a default value for the host of localhost if the user doesn't supply an option.

.option('-h, --host <host>', 'host to listen on', 'localhost')
. This default seems to be the cause of the issue. If you simply remove the default replacing the line with the following then the problem described in this issue appears to be resolved. Presumably this causes code elsewhere to use a more sensible default with listens on all hosts.

.option('-h, --host <host>', 'host to listen on')

After making this change requests are received on both localhost and the local ip address.

Ultimately, it would be great if getStorybookUI({}); automatically used the server's ip address so that it wasn't necessary to set the server ip address there.

from react-native.

yomybaby avatar yomybaby commented on August 29, 2024

Ultimately, it would be great if getStorybookUI({}); automatically used the server's ip address so that it wasn't necessary to set the server ip address there.

import {NativeModules} from 'react-native';
import url from 'url';
const {hostname} = url.parse(NativeModules.SourceCode.scriptURL);

const StorybookUIRoot = getStorybookUI({host: hostname, tabOpen: 0});

export default StorybookUIRoot;

😁

from react-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.