Giter VIP home page Giter VIP logo

Comments (4)

flochtililoch avatar flochtililoch commented on June 2, 2024 1

Great, thanks for the insights! This was a bit of a pickle and I'm glad I'm now past this issue. I wonder if it would make sense to emit a warning when configure is called more than once (as it was in my case), which could help future devs who are upgrading older projects.
Will close this issue for now.

from react-native.

dannyhw avatar dannyhw commented on June 2, 2024

@flochtililoch the configure function gets called in the generated code inside storybook.requires.js and shouldn't be directly called in your code.

from react-native.

flochtililoch avatar flochtililoch commented on June 2, 2024

@dannyhw Interesting, I've had this code configured this way since our first install of storybook 6 years ago, I must have missed this during my latest migration, though I don't remember this being called out on the migration steps.
Is the intention for configure to be called only once and by storybook.requires only?

from react-native.

dannyhw avatar dannyhw commented on June 2, 2024

@flochtililoch yes it's intended because now we generate your imports and configure should never be called twice otherwise it would cause those weird behaviours. This will enable some cool changes in v7 too.

In the official blog for the release the first step does briefly mention removing the configure call but perhaps its not super clear https://storybook.js.org/blog/storybook-for-react-native-6-5/

from react-native.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.