strahl / niell-lab-analysis Goto Github PK

What steps will reproduce the problem?
1. Set up a stimulus protocol with 'Sync to' set to something other than default
2. Save parameters
3. Restart PSC and load parameters

What is the expected output? What do you see instead?
I'd expect all parameters to load and most do, but the 'Sync to' parameter is 
not loaded.

What version of the product are you using? On what operating system?
I cloned the repository today, Jan 8 2013. I use Ubuntu Linux, but this is 
platform independent.

Please provide any additional information below.
Bugs: 
- in function SaveParams() in the last line where the parameters are saved, 
'SyncSource' is not included.
- in function LoadParams_Callback() towards the end where 'SyncSource' is set 
onto the handle the code is 
    set(handles.squaregratings,'Value',SyncSource);
should be
    set(handles.SyncSource,'Value',SyncSource);

What steps will reproduce the problem?
1. cd to directory `chronux/spikesort/mex/'
2. Enter matlab command window.
3. Run `mex CFLAGS="\$CFLAGS -std=gnu89" -largeArrayDims fast_kmeans_step.c 
-lmwblas'

  Note that the `-std=gnu89' is used to make gcc accept the c++ style comment `//'

What is the expected output? What do you see instead?
Expected: Compiled without error.
Instead : fast_kmeans_step.cpp:83:56: error: ‘dgemm_’ was not declared in 
this scope

After fix the header and function name, it still show error:
fast_kmeans_step.cpp:85:56: error: cannot convert ‘int*’ to ‘ptrdiff_t* 
{aka long int*}’ for argument ‘3’ to ‘void dgemm_(char*, char*, 
ptrdiff_t*, ptrdiff_t*, ptrdiff_t*, double*, double*, ptrdiff_t*, double*, 
ptrdiff_t*, double*, double*, ptrdiff_t*)’

After fix the function arguments, the code successfully compiled, but will 
cause Matlab to crash.
It's due to these two lines:
  plhs[0] = mxCreateNumericMatrix(mcols, 1, mxUINT32_CLASS, mxREAL);
  assigns    = (unsigned long *) mxGetPr(plhs[0]);
`mxUINT32_CLASS' is not `unsigned long' in 64bit platform.

What version of the product are you using? On what operating system?
In a 64 bit Linux system with gcc 4.7, matlab 2012.

Please provide any additional information below.
A proposed fix is attached, but need a verify.