strangerstudios / pmpro-donations Goto Github PK

The donation amount is not being stored correctly in member orders. Currently the only way to determine the donation amount is to subtract the subtotal from the total.

Additional Notes:

• Test with various payment gateways

If the user includes a dollar sign, e.g. '$10' rather than '10', in the donation field the donation is not added to the payment.
Using Version 1.1.1:
In /includes/checkout.php:
line 224 '$level->initial_payment = $level->initial_payment + $donation;' fails if $donation starts with a $ sign.
I added a workaround after line 217:
$donation = ltrim($donation, '$'); // remove any leading $ sign

Steps to Recreate

• Create a new membership level with donations enabled
• Enter content in the Help Text Field with an apostrophe
• Save the level
• Help text will keep the slashes on the frontend and backend

Environment

• WordPress 5.4.1
• PMPro 2.3.2
• Donations Add-on 1.0

Expected Behavior

• Slashes should be stripped on apostrophes

We should make sure that $settings is always initialized to an array:

Support ticket (admins only): https://www.paidmembershipspro.com/forums/topic/error-message-warning-array_merge-argument-2-is-not-an-array-in-home2/

A user has requested to display donation values separate from subscription values on the account page and invoices instead of the current combined value.

If a membership with the donation option is selected along with any other paid or free membership in the same checkout action the donation option is not displayed (help text and donation field). This is likely caused by a conflict with the Multiple Memberships Per User plugin.

Feature request to include !!donation!! variable for checkout emails.

If you choose "other" you are not setting a maximum donation limit.

The text on the webpage reads donation minimum amount to maximum amount.

If you don't set a maximum amount there is still a $ symbol on the webpage.
I wrote "choose the amount to donate" in the maximum line.
However, the $ symbol was in front of the text and looked odd.
An option may be to remove $ and have individuals write in.

Hi,

When a user enters an initial donation, the amount will carry over to PayPal Express. However, when returning to the confirmation page at the website, the donation box and text appears again and is not populated with the donation amount. If the donation amount is left blank, PayPal will not charge the donation amount. However, the amount is recorded and reflected on the PMPRO order and checkout emails.

Is there any way to skip the additional donation box on the confirmation page, or at least to change the text to read something like "Please confirm your donation amount?"

Thanks!

PMPRO ver. 1.8.4.5
Donation Plugin ver. .2
Wordpress ver. 4.2.3

When returning from PayPal Express, the donation dropdown is disabled (which is correct) but the amount shows 0.00 even if there was a donation submitted. It appears a REQUEST is used instead of SESSION.

LINE 167
<option <?php selected($price, $_REQUEST['donation']);?> value="<?php echo esc_attr($price);?>"><?php echo pmpro_formatPrice((double)$price);?></option

Updating to the below change fixes this issue.
<option <?php selected($price, $_SESSION['donation']);?> value="<?php echo esc_attr($price);?>"><?php echo pmpro_formatPrice((double)$price);?></option>

This is for version .3

If a user chooses a level and place a donation, but then cancels the purchase at the PayPal Express gateway...
When they return to the site and choose a level with not donation, the donation amount is still cached in the total and appears at PayPal checkout.

The donation session variable should clear, right?

We are using a membership level just to accept donations (creates all the same flow as for a membership so works for us). However, on the invoice, it displays Membership Cost: 0. While technically true, appears odd. Would be great to be able to override the bullets function.

I unhooked it in functions.php and then adopted it to our needs but would be great to be able to override it. Thanks

Describe the bug
For the best security and compatibility with things like payment request buttons, the donation field at checkout should be updated to use the pmpro_alter_price css selector (class).

Example here: https://github.com/strangerstudios/paid-memberships-pro/blob/dev/pages/checkout.php#L43

Has this development been abandoned please?

As a pmpro licensed user we would like this functionality. However it is incompatiple when already using the Donation add-on. The comment in the code states "Allow customers to set an additional donation amount " so it is suggesting suitability for our use case.

Hi there - I am unable to save min and max amounts, and if I leave them blank I get the following message during the 'checkout' process:

The highest accepted donation is £. Please enter a new amount.

I am therefore unable to use the donation functionality, as it prevents completion of the registration process unusable.

To confirm I was trying to set the values to 0 and 1000 and did not use any special characters. I also tried with 1 and 1000.

The price dropdown was set to 0,5,10,15,20,other

Thanks in advance for your help, and if you need any additional info, please let me know.
Chris

Add ability to mark a level as a "donation only" level. This level will:

• Give existing members their current level back after checkout.
• Give new users the donation only level.
• Allow users to checkout without creating a user or using an existing user's email address.

A user reported that in some cases the user's web browsers may autofill the donation input (text) field with parts of an address, e.g. zipcode, street number, etc., saved in the browser resulting in the user being charged for a donation value at checkout.

We could consider adding the HTML attribute autocomplete="off" for the text input field.

This could not be replicated during testing.

Moderators: # 500040

When a site owner adds a message to the donation "Help Text" field on the Levels page, additional P tags are added on each save.

Example:
The entry my custom message here will change on each save.
After 3 saves of the level, it would look like this.
<p><p><p>my custom message here</p></p></p>

https://capture.dropbox.com/BG9ipePR2J0kToP2

When you make a LEVEL donation only, and a user checks out, the Checkout-Free template is used. When a checkout is seen as "FREE," certain variables will not populate. The same for the Checkout - Free(admin) email.

Donation Amount: !!donation!!
Invoice total !!invoice-total!!

These, and possibly others, do not populate in the checkout email for a Donation Only Leve, even if you add a custom template.

Ideally, a custom template can be provided for the Donation Only email. But at least, it should not be seen as a "free" level so the needed variables are available.

https://www.paidmembershipspro.com/forums/topic/donation-box-allows-negative-amount/

reports that negative donations are deducted from the membership fee allowing for zero dollar transactions.

I uploaded and activated the Donations Add on.
I set my donation and custom field under my membership but the donations options does not display on the product. Please HELP! URGENT.

In the meantime I created a form using jot form until I solve the issue but I need help as soon as possible.

Thank you in advance for your prompt response.
URL - captainsforcleanwater.org

A user requested that there be a notification sent out to members asking for another donation on a set timeframe. I recommended a level that expires but they do not want to expire users, just remind them on a set interval that they could donate again (the level is free).

Describe the bug
If a user already has a membership level and donates by checking out for a donation-only level their level is changed to the donation-only level if the donation-only level is inside the same level group that only allows a user to have one membership level in that group.

To Reproduce
Steps to reproduce the behavior:

1. Go to Memberships > Settings > Levels, create a new level group that allows users to only select one level from this group.
2. Add a free level and a donations-only level to this group.
3. Check out for the free level.
4. Check out for the donation-only level
5. See on the membership account page that the user's level changed from the free level to the donations-only level.

Expected behavior
When a user checks out for a donation-only level their original level should not be replaced with the donation-only level.

Isolating the problem (mark completed items with an [x]):

• I have deactivated other plugins and confirmed this bug occurs when only Paid Memberships Pro plugin is active.
• This bug happens with a default WordPress theme active, or Memberlite.
• I can reproduce this bug consistently using the steps above.

WordPress Environment

Donations are not being stored in order notes.

Tested this with Stripe as payment gateway.

v2.5+ of Paid Memberships Pro introduces the pmpro_membership_ordermeta table. We should update this Add On to store the user's "donation amount" in the ordermeta.

We would need to check the version of PMPro and make sure that the table is available before completely migrating to this method as the only place the data is stored. We can make the update to save the data in two places (order notes and ordermeta) for perhaps 1 year then update to only store in ordermeta.

This would also resolve issue #25

When price dropdown values is set the checkout page the following error is returned in the debug log `[30-Aug-2019 18:22:06 UTC] PHP Notice: Undefined index: donation_dropdown in /var/sites/public_html/wp/wp-content/plugins/pmpro-donations/pmpro-donations.php on line 182′

Temporary workaround is to check whether donation_dropdown is set.

<?php if(!empty($pmprodon_allow_other) && isset($_REQUEST['donation_dropdown']) && $_REQUEST['donation_dropdown'] != 'other') { ?>

Although the add-on correctly includes donation amounts when using a payment gateway, if processing payments offline, the admin using either "+Add New Order" or "Add member", there is no field to add the donation amount to. Would like to have this functionality added.

May be possible to include it in the Pay-by-Check add-on or include it in the Add New Order/Add Member if the pmpro-donations add-on is included.

When a new user checked out for a donation only level they are assigned membership to the donation level and if they return to the levels page to make another donation they cannot select the donation only level they are a member of.

An error is being reported by "Site Health" in WordPress when this plugin is activated.
as reported by user: https://www.paidmembershipspro.com/forums/topic/donations-add-on-causing-site-health-issue/

"The REST API request failed due to an error.
Error: cURL error 28: Operation timed out after 10000 milliseconds with 0 bytes received (http_request_failed) "

We were able to replicate in a number of server environments.

Donation-only level with $0 initial payment. Visit the checkout page. Change the donation amount to get the billing fields to show. Enter info and click submit. The form won't communicate with Stripe. The PMPro backend will not get the CC info, including expiration date and will complain about that. Now that the field is loaded with a value, the checkout will work. Also works if a non-zero ?donation param is passed into the URL.

The owner has 0 as the first dropdown option. When the user selects a price, payment fields do not appear until they reload the page.

Related to #23 ?

Is your feature request related to a problem? Please describe.
A customer is trying to use PMPro and Donations together to keep things together and not have to use a separate donation plugin but a lot of the 'donation' workflow is still membership specific such as the confirmation page stating that the 'membership' is active.

Describe the solution you'd like
Ideally we can think out an alternative solution that either references 'donation' instead of membership on the confirmation and emails or separate templates for them.

Describe alternatives you've considered
A custom code solution is possible in the interim

When a customer checks out with a donation, the actual amount charged by PayPal does not include the donation. All other indications, including the price seen on the checkout page, at PayPal checkout, and the confirmation page show the donation amount included.

Steps to re-create:

1. under the Payment Settings & SSL tab set the Confirmation Step to "Skip the extra confirmation after users return from PayPal Express"

2. set up a level with donations. Say $100 initial payment.

3. at checkout choose a donation of $25

4. checkout through PayPal

5. after completing checkout, login to the merchant's or customer's PayPal account and check the transaction amount. Instead of being $125 it will only show that $100 was received by the merchant or charged to the customer. All other indications will show $125.