fs.open fails on directory about memfs HOT 7 CLOSED

It should probably emulate Node.js behaviour:

Note: The behavior of fs.open() is platform-specific for some flags. As such, opening a directory on macOS and Linux with the 'a+' flag - see example below - will return an error. In contrast, on Windows and FreeBSD, a file descriptor will be returned.

// macOS and Linux
fs.open('<directory>', 'a+', (err, fd) => {
  // => [Error: EISDIR: illegal operation on a directory, open <directory>]
});

// Windows and FreeBSD
fs.open('<directory>', 'a+', (err, fd) => {
  // => null, <fd>
});

from memfs.

For a+ flag - yes, and this is correct. But for r flag - the behaviour is different.

from memfs.

Also, the open(2) docs say:

from memfs.

Please, take a look at #59

from memfs.

Looks good, thx, I've merged it.

from memfs.

It has been released here:

https://github.com/streamich/memfs/releases/tag/v2.6.1

from memfs.

Thanks!

from memfs.