Model importer regression in master about stride HOT 15 CLOSED

@Doprez Committed the update for embedded texture!

from stride.

Ah ok, seems like the new importer is missing a step of extracting textures from the FBX file. I dont think that would be part of the model not appearing correctly but at that may at least explain the textures not getting imported in the current version.

from stride.

@Noah7071 is this just missing or a special case for this model file?

Oh yes for the case texture embedded, unlike FBX sdk there isnt auto setting in Assimp to rip embedded files. Have to generate texture image file traversing pixel by pixel. Checking in the fix shortly!

from stride.

You're a legend! I can either mark this as closed now or we can wait for the PR to close it.

from stride.

Thanks @Doprez , best mark it closed and open new if somethin else!

from stride.

Yes, there's PR of this #2163

from stride.

Im going to reopen for now so we can track it once it gets merged. It does seem fixed from Noahs example but just needs to be in master.

from stride.

Seems like it may be a path issue based on the image below:

and this check here cant find the textures causing the above error.

        private static void ImportTextures(IEnumerable<string> textureDependencies, List<AssetItem> assetReferences, Logger logger)
        {
            if (textureDependencies == null)
                return;

            foreach (var textureFullPath in textureDependencies.Distinct(x => x))
            {
                if (!File.Exists(textureFullPath))
                {
                    string texName = Path.GetFileNameWithoutExtension(textureFullPath)??"<unknown>";
                    logger.Error($"Texture with name {texName} not found");
                    continue; 
                }
                var texturePath = new UFile(textureFullPath);

                var source = texturePath;
                var texture = new TextureAsset { Source = source, Type = new ColorTextureType { PremultiplyAlpha = false } };

                // Create asset reference
                assetReferences.Add(new AssetItem(texturePath.GetFileNameWithoutExtension(), texture));
            }
        }

from stride.

@Noah7071 is this just missing or a special case for this model file?

from stride.

Thanks for sharing this @Doprez. Wheres this particular model Emily_jumpinng! ? The link you shared isn't opening for me.

from stride.

Oh weird, try this https://www.turbosquid.com/3d-models/emily-blender-2157992

from stride.

Oh lol sorry I apparently added the hyperlink without adding the actual link

from stride.

Did you already make the PR?

from stride.

Ah but that was already merged, I think it will need a new one for your commit to take effect.

from stride.

Should be fixed from @Noah7071 repo, I pulled it in this PR #2246

from stride.