strongpauly / betterset Goto Github PK

You can do this by doing .difference(...).size === 0, but that's a lot slower than just comparing the sets.

I used difference() for the first time and it's not doing what I expected. The "difference" between two sets is the relative complement. (Here's the wikipedia article. That article further lists several programming languages which also refer to this operation as the "difference."

My teammate and I both found this behavior very confusing.

The symmetric difference is of course also a thing, and seems like a useful operation to provide as well. I've always called that the disjunctive union which I think conveys the idea more clearly.

Would you consider renaming complement to difference, and difference to either symmetricDifference or disjunctiveUnion?

Of course a breaking change needs to be weighed heavily. In this case we're avoiding developer surprise. I think avoiding developer surprise is especially important for a library like this, which doesn't do much more than provide a useful interface atop one which is less useful.