stuarta0 / banking-au Goto Github PK

Hi Stuart,

I've sent you a message on linkedin in regards to your ABA implementation. Sorry for the post here, couldn't find a way of contacting you directly.

Regards
Christian

Your calculation of the net total is wrong (needs to be Math.Abs(debit - credit), and the Indicator field appears to need

    [FieldNullValue(Indicator.None)]

for it to deserialize properly.
Also you get some strange errors deserializing if you use negative amounts.

An exception is thrown when reading a file with DetailRecords containing blank Indicators. This is resolved by adding FieldNullValue as per below

[FieldFixedLength(1)]
[FieldConverter(typeof(EnumConverter), typeof(Indicator))]
[FieldNullValue(typeof(Indicator), "0")]
public Indicator Indicator;

It would be good (especially for dollar amounts!) to have some sort of warning/error mechanism for values that are too long/too big. This includes when generating the FileTotalRecord.