stuartkeith / esq1 Goto Github PK

In my tests, it looks like the pairs of bits that get broken up for the mod source of an LFO are swapped, so that serialized patches are corrupting that parameter. You just need to swap what you're doing with your modulation_source_0 and modulation_source_1 variables in serialize and deserialize. So, here: https://github.com/stuartkeith/esq1/blob/master/esq1.py#L312

Change those two lines to:

    bytes.append(modulation_source_1 + self.levels[0].value)
    bytes.append(modulation_source_0 + self.levels[1].value)

... and in deserialize (https://github.com/stuartkeith/esq1/blob/master/esq1.py#L335):

    self.modulation_source.value = modulation_source_1 +\
        (modulation_source_0 << 2)

That fixes it for me.

I'm building an ESQ-1 editor of my own, so thanks for this wonderful example!

Hi, I am playing around with the sysex_to_esq1_patches functions and I cannot figure out how to print the ESQ-1 parameters and values from the sysex files. I can view the ESQ1Patch object directory, but I don't see the parameters I am expecting, or their values. Can you update the documentation or provide an example of how to read a sysex file so that someone can input the parameters directly into the ESQ-1? My EPROM card just failed...