stuartmemo / sympathetic-synth Goto Github PK

Just a quick note to say thanks.

For a little workshop/hackaton, I've hooked up your synth to a kinect - it just took 1.5 hours. If the synth wasn't already available, this would be impossible to do.

1. We added Socket.io - it listens to playnote messages to play notes

2. We created a NodeJS socket.io server, which converts Kinect Skeletal data to notes.

3. We added a Socket.io Client to the Kinect Skeletal Demo to send data as JSON.

   Now, we could wave our hands and hear the synth playing in the browser :)

Fixing this issue, reveals a new error:

This relates to this part of the spec, which so far only looks to be implemented in Chrome

No sound is produced from clicking a key.
This is on Firefox 28 on Windows 7 64 bit.

I'm getting this error in the console:

I am using Chrome on linux - Version 52.0.2743.82 (64-bit).

tsw.js:42 Uncaught TypeError: Cannot create property 'value' on number '0'

I found this error while looking at the online demo of Sympathetic synthesisor here

The issue seems to be caused by the face that 'reduction' is a read only float, and can't be changed, as it is in

 var applySettings = function (node, settings) {
       for (var setting in settings) {              
                node[setting].value = settings[setting];
        }
    };

I have been able to fix this with the following:

    var applySettings = function (node, settings) {
       for (var setting in settings) {
            if(typeof node[setting] === "object")
            {
                node[setting].value = settings[setting];
            }
        }
    };

This was working for me up until recently so I guess it's just for the latest version of Chrome (Version 52.0.2743.82 (64-bit)).

Since this relates to TSW I have created an issue there for tracking.