Comments (6)
Its a known shortfall, xtermjs is used as the frontend to handle xterm escape codes so until mobile support is provided by that library it won't trickle down to here:
https://github.com/xtermjs/xterm.js
I think some of the newer versions of xtermjs might actually have mobile support if you were interested in trying to update the library
from sshy.
Thanks for the quick reply.
By replacing xtermjs, do you mean changing the following files?
./js/src/xterm.min.js
./css/xterm.css
Besides, I think there is something wrong with handling the virtual keyboard-popup.
Say, when keyboard-popup happens, the web page should adjust its layout dynamically so the cursor won't be covered. However, SSHy was not able to do so.
Is this something can be easily supported from your end? I'm not an expert of web design. It's your call.
from sshy.
Yeah those two files are the core pieces of xtermjs - so updating them should bring in any fixes or updates that have went into the library.
Personally I haven't done much mobile web design so I'm not entirely sure on exactly how the keyboard popup interacts with the page. Currently SSHy uses xtermjs-fit module to calculate how many rows/columns are available on the current page and sends those over to the SSH server. So if the soft keyboard interacts with the page at all to reduce the resolution then it should be quite easy to put the resize hook on that.
To note: official mobile support looks like its a WIP xtermjs/xterm.js#1101
from sshy.
I did a naive swap of both ./js/src/xterm.min.js and ./css/xterm.css with current official release.
It seems you can't update lib this way.
First of all, replacing ./css/xterm.css breaks the page.
Second, replacing ./js/src/xterm.min.js or even removing it does absolutely no effect to anything...
I did clear cache by performing a "empty cache and hard reload" from user end and restart the server..
from sshy.
If you're changing any of the JavaScript for SSHy you'll need to rebuild the distributed js file. Check the Build section in the readme for the commands
I wouldn't be surprised that the css update on its own might break the page but there could be a couple things in there that are relied on. Not something I can remember unfortunately 😢
from sshy.
Thanks a lot..
I was wondering how index.html was able to access code in xterm.js without even reference it once. It turns out that all js code is bundled into combinedLibs.comb.js.. Guess I'm really new in this area...
from sshy.
Related Issues (20)
- Question and Possible bug. HOT 4
- Question: SSHy as angular/vue component?
- Keeps loading without connecting - wsproxy problem HOT 1
- can we have a ssh client that needs to creds
- Is there any way to include user name in wrapper.html? HOT 2
- Stuck on connecting... HOT 4
- Question: Predefined commands? HOT 2
- Support for binary websockets HOT 3
- Better error handling
- Error connecting to Debian / OpenSSH 7.4 HOT 6
- DOMException: Failed to execute 'atob' on 'Window' HOT 1
- Unable to closure-compile or connect HOT 1
- Safari support
- Really dumb question
- Stopped working with latest browsers HOT 28
- Can't send return key in latest Chrome 90.0.4430.93 HOT 1
- Failed to execute 'atob' on 'Window'
- Latest Chrome Update broke user return HOT 2
- WebSocket connection failed: Error in connection establishment: code 1005 HOT 2
- Invalid Signature Using Public Key Auth
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sshy.