stuvusit / ansible_systemd_timesyncd Goto Github PK

Ansible beginner here, so maybe I'm doing something stupid. But running the example playbook gets me this:

$ ansible-playbook workstations-ntp-conf.yml 
ERROR! We were unable to read either as JSON nor YAML, these are the errors we got from each:
JSON: Expecting value: line 1 column 1 (char 0)

Syntax Error while loading YAML.
  mapping values are not allowed in this context

The error appears to be in '/home/jakob.donotbackup/code/mfg-ansible/workstations-ntp-conf.yml': line 4, column 22, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

  - systemd-timesyncd
    timesync_timezone: Europe/Berlin
                     ^ here

yamllint.com does not like it either:

Hi, instead of coding the logic to configure timezone, it's better to use the default module of Ansible : https://docs.ansible.com/ansible/latest/modules/timezone_module.html

Some systems (e.g. RHEL and its derivatives such as CentOS) have a separate package systemd-timesyncd which needs to be installed before attempting to enable and start the service.

Hi,

My servers have no access with Internet.
I would need a tarball accessible from Github.

Can you please make a release by tagging your master branch?

Thank you very much.

Changes made in dac573c depend on Aptitude being installed on the target server, which is generally not true - it fails on current Ubuntu LTS ( and IIRC Debian Stable doesn't install Aptitude either). The code is somewhat suspicious too: systemd-timesyncd might not be installable, but we start the unit anyway?

I created a PR to fix the issue: #17

EDIT. better explain what was tested

Hi,

I just ran this role against a pizero which doesn't have a RTC. In that case, the "Write adjtime" handler fails:

hwclock: Cannot access the Hardware Clock via any known method.
hwclock: Use the --debug option to see the details of our search for an access method.

To fix, one could either:

1. Add a variable "skip_rtc_update" or similar to skip the handler
2. Try to detect if /dev/rtc exists and skip the handler if it doesn't
3. Add a variable to specify the RTC device and a special value to skip RTC updates

I could create a PR for one of those options.

Hello :)

could you please add tags on your code ?
thanks a lot ! it working great !