The current language definition does not highlight variables/definitions within any kind of quotes, this should probably be changed.

Hi,

the colors of the keywords changed with the new version. I expected the update to also highlight the variables in strings, but with the same color as before:

Old:

New:

I use the Afterglow theme in standard configuration. There was no change to the theme.
Sublime version: Dev Channel, Build 3125

This package currently lacks Goto Definition / Goto Reference support. As far as I know, there are at least four scenarios where this makes sense:

1. Functions

# Definition
Function someFunction
FunctionEnd

# Reference
Call someFunction

2. Macros

# Definition
!macro someMacro
!macroend

# Reference
!insertmacro someMacro

3. Defines

# Definition
!define VERSION "1.2.3"

# Reference
DetailPrint "This is version ${VERSION}"

4. Variables

# Definition
Var "someVar"

# Reference
DetailPrint "Printing $someVar"

Note: When variables are declared, no value is assigned. Hence, the benefit Goto Definition might be limited

Example:

# Definition
Var "someVar"

# Value assignment
StrCpy $someVar "World"

# Reference
DetailPrint "Hello $someVar"

# Value re-assignment
StrCpy $someVar "John Doe"

All PRs to add Goto Definition / Goto Reference support are appreciated!

Currently PackageControl allows you to install this (and lists it as ST3 compatible) but running Build (Ctrl+B) the package complains about not being able to find the .bat file.

CC @jeffory @FichteFoll

Is there any opposition to tagging releases? I would like to convert the current TextMate file to the new format for for syntax definitions and thought that versioning illustrate this cut nicely.

The conversion itself can be done using convert_syntax.py inside the Default package in (build 3103 and later).

Proposal:

• 1.0.0 for TextMate XML (.tmLanguage)
• 2.0.0 for Sublime Text YAML (.sublime-syntax)

Any arguments against this?

i installed NSIS plugin via package control of sublime text 4, on status bar it hints "installation sucessfully", but indeed not. Nothing happend.

Could someone please change the package description and remove the 2 from "Sublime Text 2". The versioned releases are now live on Package Control and I think the description should communicate it works with ST2 and ST3.

I have noticed that multiline comments are not working as they should, Sublime Text will comment out every single line rather than using /multiline comments/. I had a quick look at the tmLanguage file, but couldn't figure out why the multiline comments aren't working. No big deal, but I didn't want to leave this unmentioned.

In my opinion, the highlighting of blocks (Section/SectionEnd, Function/FunctionEnd, PageEx/PageExEnd) should be adjusted to match that other languages. Specifically, the mentioned commands to open/close a block should be highlighted as other.keyword.nsis, while their names should be entity.name.function.nsis.

Adjusting Section is fairly complex, since there many cases to consider, e.g. optional quotes around the name, optional parameters, special prefixes and section indices.

Section NameOfSection
SectionEnd

Section "Name of Section with Spaces"
SectionEnd

Section -hiddenSection
SectionEnd

Section "-hidden section"
SectionEnd

Section # hidden section
SectionEnd

Section !boldSection
SectionEnd

Section "!bold section"
SectionEnd

Section /o "optional section"
SectionEnd

Section "section with named index" SECTION_INDEX
SectionEnd

All PRs to improve block highlighting are appreciated.

Hello,

with Sublime 3114 the syntax file for Nsis is causing following error:

The corresponding lines in the file are:

- match: (\!include|\!insertmacro)\b
  captures:
  match: keyword.control.import.nsis

Regards,
Robin

I could only find other packages related to "NSIS", but no "NSIS" renamed there.

I also tried to download manually, but it didn't work when I re-started my SublimeText.

This package currently lacks Goto Symbol support. It's up to discussion which language features deserve this, but there are several options to choose from:

• Section
• Function
• PageEx (maybe)
• !macro (maybe)

All PRs to add Goto Symbol are appreciated!

The current file https://github.com/SublimeText/NSIS/blob/master/nsis_build.bat doesn't seem to support adding make_nsis to the PATH or via some other way except locally installing it.

This makes a portable Sublime Text with a portable NSIS not possible.