substra / substrafl Goto Github PK

What are you trying to do?

I run a script inside my package that I want to list as a dependency, while copying my package it creates a temp directory holding the copy, and then it tries to copy that folder as well, which already contains the package and so forth until disk space runs out.

Issue Description (what is happening?)

Pretty much self explanatory

Expected Behavior (what should happen?)

It should copy only relevant files

Reproducible Example

No response

Operating system

MacOS

Python version

3.9.16

Installed Substra versions

0.35.Orc1

Installed versions of dependencies

No response

Logs / Stacktrace

No response

What are you trying to do?

Change aggregation lr in Scaffold

Issue Description (what is happening?)

It is impossible to set a different aggregation_lr than 1.

Expected Behavior (what should happen?)

Result of experiment should change

Reproducible Example

No response

Operating system

MacOS (but irrelevant)

Python version

3.10

Installed Substra versions

substrafl 0.34.0

Installed versions of dependencies

No response

Logs / Stacktrace

No response

What are you trying to do?

I am passing a larger than the dataset's size batch size so that I am sure that the whole dataset is loaded at every update on all clients.
I get this log:

2023-04-13 08:56:18,519 - INFO - The batch size (9223372036854775807) is greater than the number of samples: n_samples.This is not allowed. Batch_size is now updated to equal number of samples (200)

Then afterwards I get a memory allocation error in local_predict because it's allocating:

batch = [0] * self.batch_size # with self.batch_size=9223372036854775807

And self.batch_size was not updated to 200 contrary to what the log says.

Issue Description (what is happening?)

OOM because the fix is not applied

Expected Behavior (what should happen?)

The batch_size should be set to 200

Reproducible Example

No response

Operating system

MacOS

Python version

3.9.16

Installed Substra versions

0.35.0

Installed versions of dependencies

No response

Logs / Stacktrace

No response

Describe the bug

TestDataNode docs states:
metric_keys (List[[str](https://docs.python.org/3/library/stdtypes.html#str)]) – Substra metric keys to the metrics, use substra.Client().add_algo().

It should instead talk about add_metric not add_algo and provide a more detailed explanation such as:
the metric key is the hash of the metric created by the add_metric method of the Client (substra.Client().add_metric()). It can be accessed by inspecting the result of the method's call or retrieved from the frontend in deployed mode.

Screenshots

Environment

NA