sulu / sulucommentbundle Goto Github PK
View Code? Open in Web Editor NEWSulu comment bundle
License: MIT License
Sulu comment bundle
License: MIT License
Q | A |
---|---|
Bug? | no |
New Feature? | no |
Sulu Version | > 1.0.0 |
Browser Version | --- |
CommentType disable csrf protection by default.
CSRF Protection should be enabled by default. But this will change the behaviour of AJAX requests.
Q | A |
---|---|
Bug? | Yes |
New Feature? | no |
Comment Bundle Version | 2.0.0 |
Browser Version | Chrome Version 124.0.6367.118 (Official Build) (64-bit) |
After creating a comment, the thread title is empty
Thread title should be filled in with what's passed as a template variable as described in the official docs
{{ render(path('sulu_comment.get_threads_comments', {
threadId: 'page-' ~ uuid,
referrer: app.request.uri,
threadTitle: 'This is my thread title',
_format: 'html'
})) }}
Q | A |
---|---|
Bug? | no |
New Feature? | yes |
Sulu Version | 2.x |
Browser Version | Browser name and version |
Should work with latest Sulu bundle and PHP 8
Is there already work being done to make this work with PHP 8 and latest Sulu 2.5?
Q | A |
---|---|
Bug? | no |
New Feature? | yes |
Sulu Version | none |
In the thread-form there should be a tab with a list of related comments. From there you should be able to goto the comment-form and back.
Q | A |
---|---|
Bug? | yes |
New Feature? | no |
Sulu Version | Bundle 2.0.0; Sulu 2.5.10 |
When Comment-form validation fails a 400-http-Response is sent back.
Comments form with validation errors is shown.
Extend Comment entity and CommentForm type and add a property with some constraint (eg. NotBlank).
On submission of empty form the validation fails and a "Bad Request" Response (400) is sent back to the client.
Change form-action to referrer and let the form handle the request there?
Q | A |
---|---|
Bug? | yes |
New Feature? | no |
Sulu Version | Bundle 2.0.0; Sulu 2.5.10 |
Threads are created without a title.
Threads get the title of the page/article they belong to.
Add comments form to article detail view and submit a comment -> a thread w/o a title is created.
Pass the Request-Param $threadTitle = $request->get('threadTitle') as an option to the comments-form when creating it inside \Sulu\Bundle\CommentBundle\Controller\WebsiteCommentController::cgetCommentsAction.
The rest can then be handled by extending the form-type and adding the intended title to the twig-render-call inside the article template.
Q | A |
---|---|
Bug? | no |
New Feature? | no |
Sulu Version | <1.5 |
Browser Version | all |
The tests should run with --prefer-lowest
. The problem is that sulu 1.3
is not able to run the tests with lowest.
Q | A |
---|---|
Bug? | yes |
New Feature? | no |
Sulu Version | 2.5.13 |
Sulu Comment Bundle Version | 2.0.0 |
Browser Version | Google Chrome Version 123.0.6312.86 (Official Build) (64-bit) |
It is possible to manipulate or delete existing comments / threads by simply sending post requests to the WebsiteController:
e.g. https://localhost:8000/threads/b69cc46e-9527-48b5-a98d-3a3634c41f05/comments/2
Neither the WebsiteController nor the CommentManager validates the current user with the creator of the comment.
Only the creator of the comment should be able to delete or edit the comment.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.