@SungMatt We did an automated analysis of your code to detect potential areas to improve the code quality. We are sharing the results below, to help you improve the iP code further.
IMPORTANT: Note that the script looked for just a few easy-to-detect problems only, and at-most three example are given i.e., there can be other areas/places to improve.
Aspect: Tab Usage
No easy-to-detect issues 👍
Aspect: Naming boolean variables/methods
No easy-to-detect issues 👍
Aspect: Brace Style
No easy-to-detect issues 👍
Aspect: Package Name Style
No easy-to-detect issues 👍
Aspect: Class Name Style
No easy-to-detect issues 👍
Aspect: Dead Code
Example from src/main/java/mattbot/MattBot.java lines 29-29:
// List<Task> taskList = new ArrayList<Task>();
Example from src/main/java/mattbot/Storage.java lines 34-34:
Suggestion: Remove dead code from the codebase.
Aspect: Method Length
Example from src/main/java/mattbot/MattBot.java lines 27-175:
public static void main(String[] args) {
// Load save file
// List<Task> taskList = new ArrayList<Task>();
try {
mattmory = new Storage();
tasks = mattmory.load();
} catch (IOException e) {
System.out.println(e);
tasks = new TaskList();
}
/*String logo = " ____ _ \n"
+ "| _ \\ _ _| | _____ \n"
+ "| | | | | | | |/ / _ \\\n"
+ "| |_| | |_| | < __/\n"
+ "|____/ \\__,_|_|\\_\\___|\n";
System.out.println("Hello from\n" + logo);*/
System.out.println("____________________________________________________________");
System.out.println("Hello! I'm " + NAME);
System.out.println("What can I do for you?");
System.out.println("____________________________________________________________");
Scanner sc = new Scanner(System.in);
String userInput;
label:
while (true) {
// Take user input in, and process user input
userInput = sc.nextLine();
String command = userInput.split(" ", 2)[0];
switch (command) {
case "bye":
printTop();
System.out.println("Bye, Hope to see you soon!");
printBottom();
break label;
case "list":
printTop();
for (int i = 0; i < tasks.size(); i++) {
Task t = tasks.getTask(i + 1);
System.out.println(String.format("%d. %s", i + 1, t));
}
printBottom();
break;
case "mark": {
printTop();
int taskId = Integer.parseInt(userInput.split(" ", 2)[1]);
tasks.markTask(taskId);
mattmory.writeBack(tasks);
Task t = tasks.getTask(taskId);
System.out.println("Great job! You have completed the task " + t.showName());
printBottom();
break;
}
case "unmark": {
printTop();
int taskId = Integer.parseInt(userInput.split(" ", 2)[1]);
tasks.unmarkTask(taskId);
mattmory.writeBack(tasks);
Task t = tasks.getTask(taskId);
System.out.println("Oh no, you have uncompleted " + t.showName());
printBottom();
break;
}
default: {
int len = userInput.split(" ", 2).length;
if (len <= 1) {
printTop();
System.out.println("Oh no, your input is bad.");
System.out.println(command + " requires an argument.");
printBottom();
continue;
}
printTop();
String arguments = userInput.split(" ", 2)[1];
Task t;
if (command.equals("todo")) {
t = new Todo(arguments);
tasks.addTask(t);
mattmory.writeBack(tasks);
System.out.println("I've added this to your tasks: ");
System.out.println(t);
} else if (command.equals("deadline")) {
String name = arguments.split(" /by ", 2)[0];
String dueDate = arguments.split(" /by ", 2)[1];
try {
LocalDateTime dtDueDate = LocalDateTime.parse(dueDate, PRINT_DTF);
t = new Deadline(name, dtDueDate);
tasks.addTask(t);
mattmory.writeBack(tasks);
System.out.println("I've added this to your tasks: ");
System.out.println(t);
} catch (DateTimeParseException e) {
System.out.println("Your date is invalid. It should be in the form YYYYMMDDTHHMM."
+ " An example is 20231231T2359.");
}
} else if (command.equals("event")) {
String name = arguments.split(" /from ", 2)[0];
String dates = arguments.split(" /from ", 2)[1];
String startDate = dates.split(" /to ")[0];
String endDate = dates.split(" /to ", 2)[1];
try {
LocalDateTime dtStartDate = LocalDateTime.parse(startDate, PRINT_DTF);
LocalDateTime dtEndDate = LocalDateTime.parse(endDate, PRINT_DTF);
t = new Event(name, dtStartDate, dtEndDate);
tasks.addTask(t);
mattmory.writeBack(tasks);
System.out.println("I've added this to your tasks: ");
System.out.println(t);
} catch (DateTimeParseException e) {
System.out.println("Your date is invalid. It should be in the form YYYYMMDDTHHMM."
+ "An example is 20231231T2359.");
}
} else if (command.equals("delete")) {
if (tasks.size() == 0 || tasks.size() < Integer.parseInt(arguments)) {
System.out.println("Oops, you're deleting a task that doesn't exist.");
continue;
}
t = tasks.getTask(Integer.parseInt(arguments));
System.out.println("I have removed this task:");
System.out.println(t);
tasks.removeTask(Integer.parseInt(arguments));
mattmory.writeBack(tasks);
} else if (command.equals("find")) {
ArrayList<Task> found = new ArrayList<Task>();
for (int i = 1; i <= tasks.size(); i++) {
t = tasks.getTask(i);
if (t.showName().contains(arguments)) {
found.add(t);
}
}
if (found.size() == 0) {
System.out.println("Oh no, I can't seem to find any tasks matching " + arguments + ".");
continue;
}
System.out.println("I have found " + found.size() + " tasks matching your search!");
for (int i = 0; i < found.size(); i++) {
t = tasks.getTask(i+1);
System.out.println(String.format("%d. %s", i + 1, t));
}
} else {
System.out.println("I didn't quite understand your input.");
continue;
}
printBottom();
break;
}
}
}
}Suggestion: Consider applying SLAP (and other abstraction mechanisms) to shorten methods e.g., extract some code blocks into separate methods. You may ignore this suggestion if you think a longer method is justified in a particular case.
Aspect: Class size
No easy-to-detect issues 👍
Aspect: Header Comments
No easy-to-detect issues 👍
Aspect: Recent Git Commit Message
possible problems in commit cb16377:
Merge branch 'Level-9'
Add find functionality.
- No blank line between subject and body
possible problems in commit fdb16f9:
Refined Todo coding standards
- Not in imperative mood (?)
possible problems in commit f8f554e:
- Subject line should not end with a period
Suggestion: Follow the given conventions for Git commit messages for future commits (no need to modify past commit messages).
Aspect: Binary files in repo
No easy-to-detect issues 👍
ℹ️ The bot account used to post this issue is un-manned. Do not reply to this post (as those replies will not be read). Instead, contact [email protected] if you want to follow up on this post.
React
Typescript
Django
Laravel
Facebook
Microsoft
Google
Alibaba
D3
Tencent