Comments (5)
For now, you can use patch-package to do the change locally:
Example diff: (v6.7.0)
diff --git a/node_modules/connected-react-router/index.d.ts b/node_modules/connected-react-router/index.d.ts
index c56beb1..5d59f58 100644
--- a/node_modules/connected-react-router/index.d.ts
+++ b/node_modules/connected-react-router/index.d.ts
@@ -91,7 +91,7 @@ declare module 'connected-react-router' {
}
export class ConnectedRouter<S = LocationState> extends React.Component<
- ConnectedRouterProps<S>,
+ React.PropsWithChildren<ConnectedRouterProps<S>>,
{}
> {}
The TSC error went away for me :)
from connected-react-router.
Facing same problem
from connected-react-router.
I believe this is because of React 18 changing typing for children
from connected-react-router.
same issue, anyone found out whats going on ?
from connected-react-router.
@tanzeelrana as mentioned above, react 18 changed the typing for children. AFAIK the children prop used to be included by default, now its not. You need to either add it manually to your props interface (something like "children?: React.ReactNode | undefined;") OR wrap your props in React.PropsWithChildren (React.PropsWithChildren).
What that likely means in the scope of this library, is that until the maintainer updates the props for his interfaces to include the children prop, this library is incompatible with react 18.
from connected-react-router.
Related Issues (20)
- Could not find router reducer in state tree, it must be mounted under "router"
- Missing typing for the default component property `children` for react@17 HOT 1
- Can't install package with React 18.1 HOT 5
- `history.replace` is not working after upgrading to 6.9.2 version HOT 1
- Add support for react-redux v8.0.2
- Support [email protected] HOT 1
- Is connected-react-router compatible with react 18? HOT 8
- This project appears to be out of maintenance HOT 3
- Upgrade peer dependencies to support React 18 HOT 1
- When will support react@18 & [email protected] & [email protected] HOT 1
- Incompatibility with history.listen with history@5
- Will support react-router v6 and history v5? HOT 2
- Redirect not working in react-router-dom v6 HOT 1
- Expose an Error Handler
- How to reset the states with connect-react-router HOT 1
- VSCode - Integrated Console stops responding
- When will the support come for react@18? HOT 2
- Is the project DEAD??? HOT 2
- link button not working second when i added new maincategory, it is rendering same component intead of going path
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from connected-react-router.