Semi-incompatible with Realistic World Generation about biometweaker HOT 4 CLOSED

The issue is located in this method:

https://github.com/Ted80-Minecraft-Mods/Better-World-Generation-4/blob/master/bwg4/world/ChunkManagerRealistic.java#L142

Whereas the vanilla method consults the BiomeManager for biomes, RWG's method does not. Vanilla method is detailed below:

IntCache.resetIntCache();

    if (p_76937_1_ == null || p_76937_1_.length < p_76937_4_ * p_76937_5_)
    {
        p_76937_1_ = new BiomeGenBase[p_76937_4_ * p_76937_5_];
    }

    int[] aint = this.genBiomes.getInts(p_76937_2_, p_76937_3_, p_76937_4_, p_76937_5_);

    try
    {
        for (int i1 = 0; i1 < p_76937_4_ * p_76937_5_; ++i1)
        {
            p_76937_1_[i1] = BiomeGenBase.getBiome(aint[i1]);
        }

        return p_76937_1_;
    }

The crucial call is

int[] aint = this.genBiomes.getInts(p_76937_2_, p_76937_3_, p_76937_4_, p_76937_5_);

This conults the GenLayer class, which, when instantiated, consults the BiomeManager. GenLayer asks the BiomeManager for biomes when it is instantiated:

for (BiomeManager.BiomeType type : BiomeManager.BiomeType.values())
    {
        com.google.common.collect.ImmutableList<BiomeEntry> biomesToAdd = BiomeManager.getBiomes(type);
        int idx = type.ordinal();

        if (biomes[idx] == null) biomes[idx] = new ArrayList<BiomeEntry>();
        if (biomesToAdd != null) biomes[idx].addAll(biomesToAdd);
    }

The fix for this issue will not be easy from an outside source. The options are to either ask the author to consult the BiomeManager, or to use ASM to directly modify the method. I will probably ask the author before resorting to ASM.

from biometweaker.

I'm going to leave this here so that the author may see this.
@ted80

from biometweaker.

Alright, seems quite complicated from a non-Java dev perspective.but I suppose RWG is still in alpha as well so incompatibility can be expected. Already happy I can make some changes to the biomes using BiomeTweaker :)

Don't suppose he'll respond to this since I already PM'ed him about something else regarding compatibility and he just ignored me, and he doesn't seem to be replying to posts on his mod thread either but perhaps he'll make it compatible with BiomeTweaker anyway.

Anyways, thanks for the help.

from biometweaker.

That's unfortunate. I'm going to add a known bugs and incompatibilities section.

This issue will stay open for a while - until it seems as though the author of RWG will not respond.

from biometweaker.