Giter VIP home page Giter VIP logo

Comments (4)

superckl avatar superckl commented on May 27, 2024

The crash actually results from him loading the model classes on the server. He never actually does anything with them which is why his mod doesn't crash outright. I first encountered this issue with QuiverBows.

BiomeTweaker attempts to resolve super classes so that it can patch any classes that improperly override color methods in BiomeGenBase. When it does this, it fails to resolve the model classes since they simply aren't there. Luckily, there is a way to fix this on my end until @Ivorforce manages to get the models classes to not load on the server. Either way, you're going to need an unreleased version of BiomeTweaker, build 101 or later. I would recommend downloading the latest build (107).

With the latest build, everything should work fine, but you will see some exceptions from BiomeTweaker. If those are really annoying you, you can do two things.

  1. Enable light asm mode. This will cause BiomeTweaker to not do any superclass resolution. This will break color overrides in some biomes, but the errors will disappear.
  2. Add the classes to the ASM blacklist. BiomeTweaker will ignore only those classes when resolving superclasses. This is the best solution, but you need to be able to find what classes are causing the crash.

Again, you don't have to do either of these. The latest build will work regardless. These will just remove the errors. I will close this issue when I release version 1.0.

from biometweaker.

Qohelethh avatar Qohelethh commented on May 27, 2024

Thanks for your detailed reply. I'll download the latest version and give
it a try.
On 29 May 2015 20:51, "Chris" [email protected] wrote:

The crash actually results from him loading the model classes on the
server
https://github.com/Ivorforce/YeGamolChattels/blob/master/src/main/java/ivorius/yegamolchattels/blocks/EnumPedestalEntry.java#L13.
He never actually does anything with them which is why his mod doesn't
crash outright. I first encountered this issue with QuiverBows.

BiomeTweaker attempts to resolve super classes so that it can patch any
classes that improperly overrides color methods in BiomeGenBase. When it
does this, it fails to resolve the model classes since they simply aren't
there. Luckily, there is a way to fix this on my end until @Ivorforce
https://github.com/IvorForce manages to get the models classes to not
load on the server. Either way, you're going to need an unreleased version
of BiomeTweaker, build 101
http://jenkins.superckl.me/job/BiomeTweaker/101/ or later. I would
recommend downloading the latest build (107)
http://jenkins.superckl.me/job/BiomeTweaker/107/.

With the latest build, everything should work fine, but you will see some
exceptions from BiomeTweaker. If those are really annoying you, you can do
two things.

  1. Enable light asm mode. This will cause BiomeTweaker to not do any
    superclass resolution. This will break color overrides in some biomes, but
    the errors will disappear.
  2. Add the classes to the ASM blacklist. BiomeTweaker will ignore only
    those classes when resolving superclasses. This is the best solution, but
    you need to be able to find what classes are causing the crash.

Again, you don't have to do either of these. The latest build will work
regardless. These will just remove the errors. I will close this issue when
I release version 1.0.


Reply to this email directly or view it on GitHub
#25 (comment)
.

from biometweaker.

Ivorforce avatar Ivorforce commented on May 27, 2024

Hrm, the classes are not annotated with @SideOnly for whatever reason, which is why it slipped by me and I just load them on the server too. I guess I'll make a note to change that on my end, too - the enums are bad design anyway.

from biometweaker.

superckl avatar superckl commented on May 27, 2024

http://minecraft.curseforge.com/mc-mods/228895-biometweaker/files/2241592

from biometweaker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.