superflytv / supertimeline Goto Github PK

The .npmignore excludes the src directory from the NPM package and the repository doesn't contain any compiled code, which makes the package unusable when linked as a Git repository.

in the README.MD example some Caps are not there

Timeline.resolver.getTimelineInWindow
should be
Timeline.Resolver.getTimelineInWindow

Timeline.enums.TriggerType.
should be
Timeline.Enums.TriggerType.

etc etc
``

kind regards maurice

• I'm submitting a ...
  [x] bug report
  [x] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary
  I don't know if this is a feature request or a bug report ;)
  if I change this (works)

{ // This object defines a graphic, to be overlaid on the video
        id: 'graphic0',
        layer: 'L2',
        enable: {
            start: '#video0.start + 10', // 10 after video0 starts
            duration: 10
        },
        content: {},
        classes: ['graphics']
    }

into this

{ // This object defines a graphic, to be overlaid on the video
        id: 'graphic0',
        layer: 'L2',
        enable: {
            start: '#video0.duration / 2', // graphic should start halfway 
            duration: 10
        },
        content: {},
        classes: ['graphics']
    }

it does not work.
I don't know how far / if this kind of (start / end / duration) manipulation is supported
if not supported this is a feature request ;) other wise a bug report

• I'm submitting a ...
  [x] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
  [ ] question about how to use this project

• Summary
  A keyframe in an object in a group will only resolve if it starts at the same time as the object in the group, but never when it is offset.

• Other information
  I tried to put the keyframes on the group instead, and have a logical trigger to the object inside the group but that didn't seem to work.

The typescript tells that the api always returns a StartTime object, but because of a // @ts-ignore a plausible outcome is for the resolveObjectStartTime method in resolver.ts to return null.

I don't know what the expected output should be. It is possible to specify that the outcome can be null (or undefined which is ofter better);

function resolveObjectStartTime (obj: TimelineResolvedObject|TimelineResolvedKeyframe, resolvedObjects: ResolvedObjectsStore): StartTime|undefined {

...
        let startTime: StartTime|undefined
	if (!_.isUndefined(obj.resolved.startTime)) {
		startTime = obj.resolved.startTime
	}

	return startTime
}