Giter VIP home page Giter VIP logo

redux-demo's Introduction

redux-demo's People

Contributors

bebraw avatar koox00 avatar sapegin avatar thehunmonkgroup avatar tvilon avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

redux-demo's Issues

Unable to rename lanes.

Clicking on the lanes title now triggers update without allowing the user to change the name. notes works fine.

delete note trigger a bug

In the immutable_app part, I follow the way to run, clone,cd,npm install,(I skip the "phantomjs-prebuilt": "^2.1.7",because of the Error.), then I run the "npm run start" instruction to run.
At first,all is ok,but when I click the node delete button,the page alert Error,just as follows:

TypeError: note is undefined
render/<
E:/kanban/redux-demo-master1/immutable_app/app/components/Notes.jsx
mapFactory/mappedSequence.__iterateUncached/<
http://localhost:8080/app.js:1993
List.prototype.__iterate
http://localhost:8080/app.js:1993
mapFactory/mappedSequence.__iterateUncached
http://localhost:8080/app.js:1993
seqIterate
http://localhost:8080/app.js:1993
IndexedSeq.prototype.__iterate
http://localhost:8080/app.js:1993
.toArray
http://localhost:8080/app.js:1993

I compare the immutable_app part with the kanban_app,except for the immutablejs part,every thing is the same.I have no idea how to figure it.

Thanks for your help!

Firefox:the notes state is one more than it should be.

When running my Kanban demo,I come across a problem, the nodes property of the state in the redux-devtools always come up to be one more than the actural ones.

For example,initial in the view page,there is only one "add button" which controls the adding of the lane, in this case, the state of the redux-devtools should be "lanes: [ ] 0 items; notes: [ ] 0 item",but it turn to be "lanes: [ ] 0 items; notes: [ ] 1 item";

I trire several ways "localStorage.clear();localStorage.debug = 1; localStorage.debug = 0;",clear the cache. But it return unchanged.

The version of my firefox is 45.0.2;in the chrome,all is ok.So should I pull-request at here or in the redux-devtools repository?

UUIDs should be generated in the action creators instead of in the reducers

It's kind of a nitpicky thing, but when there are "impure" things in the reducers (such as random ID generation), it can break the devtool functionality (which is a big selling point of Redux). If you instead generate the IDs in the action creators and send the generated IDs as part of the action, then the IDs will still be consistent when you're doing things like undoing and replaying actions using the devtools.

Minimal Documentation Request

I love that you ported the Kanban application into Redux. It's great to look at how the two solutions compare on the same project.

I think however, that the value of this project would go up a lot, if you added some minimal documentation on the Redux particularities.

Specifically, for me personally, the Redux DevTools are still somewhat obscure.

And even more specifically, could you explain (either in this issue, and / or subsequently in the README, and / or in the code) these:
https://github.com/survivejs-demos/redux-demo/blob/master/kanban_app/app/store/configureStore.dev.js#L8-L15
https://github.com/survivejs-demos/redux-demo/blob/master/kanban_app/app/store/configureStore.dev.js#L20-L26

I think people will appreciate! :)
Thank you.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.