svenkubiak / jbcrypt Goto Github PK

The BCrypt code wrapped by this package compiles fine with a compiler target of 1.5, but this package's POM sets it to 1.8. This unfortunately means that JDK 1.8 is the minimum requirement for the artifacts released on Maven Central, even though the code itself works fine with JDK 1.5.

You say:

The classes have been moved to a java package to avoid pollution of the global namespace. org.mindrot was chosen to reflect their original origin.

However, when I download http://www.mindrot.org/files/jBCrypt/jBCrypt-0.4.zip I see that the first line in BCrypt.java is "package org.mindrot.jbcrypt;". So what do you mean that the classes have been moved to a java package? They seem to already be in a Java package to me.

Hi there,

Thanks for your work on this.

I'd like to ask, is there any reason hashpw method works with String instead of char[]? Wouldn't it be better if array was used, as it's not interned and may be removed from memory?

The readme states

jBCrypt is licensed under a ISC/BSD licence. See the LICENSE file for details.

but said file doesn't exist.

Given the clause from https://github.com/jeremyh/jBCrypt/blob/master/LICENSE that reads "provided that the above copyright notice and this permission notice appear in all copies" I think it needs to be added 😄