svenstaro / proxyboi Goto Github PK

This is against spec and must never happen.

The proxy binaries are currently built (also) for Linux arm and arm64. However the docker hub container is only released for x86-64.

It would be nice to have the 🐳 containers also released for arm64 (which would allow running the proxy, dockerized, on Raspberry PI for example).

Potential suggestion solution: using docker manifests. However i did not find how is the current image built & published to the hub registry.

Question isn't codegen ignored if we have set lto to true?

> cargo install proxyboi

error[E0432]: unresolved import `clap::Clap`
 --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:2:5
  |
2 | use clap::Clap;
  |     ^^^^^^^^^^ no `Clap` in the root

error[E0432]: unresolved import `clap::Clap`
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/main.rs:13:5
   |
13 | use clap::Clap;
   |     ^^^^^^^^^^ no `Clap` in the root

error: cannot determine resolution for the derive macro `Clap`
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:28:10
   |
28 | #[derive(Clap, Debug, Clone)]
   |          ^^^^
   |
   = note: import resolution is stuck, try simplifying macro imports

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:29:3
   |
29 | #[clap(
   |   ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:38:7
   |
38 |     #[clap(short, long, default_value = "0.0.0.0:8080")]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:42:7
   |
42 |     #[clap(short = 'k', long)]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:46:7
   |
46 |     #[clap(short, long)]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:50:7
   |
50 |     #[clap(short, long)]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:54:7
   |
54 |     #[clap()]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:58:7
   |
58 |     #[clap(long = "upstream-header", parse(try_from_str = parse_header))]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:62:7
   |
62 |     #[clap(long = "response-header", parse(try_from_str = parse_header))]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:66:7
   |
66 |     #[clap(long, default_value = "5")]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:70:7
   |
70 |     #[clap(long = "cert", requires = "tls-key")]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error: cannot find attribute `clap` in this scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:74:7
   |
74 |     #[clap(long = "key", requires = "tls-cert")]
   |       ^^^^
   |
   = note: `clap` is in scope, but it is a crate, not an attribute

error[E0599]: no function or associated item named `parse` found for struct `ProxyboiConfig` in the current scope
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/main.rs:46:34
   |
46 |     let config = ProxyboiConfig::parse();
   |                                  ^^^^^ function or associated item not found in `ProxyboiConfig`
   |
  ::: .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/config.rs:36:1
   |
36 | pub struct ProxyboiConfig {
   | ------------------------- function or associated item `parse` not found for this
   |
   = help: items from traits can only be used if the trait is implemented and in scope
   = note: the following traits define an item `parse`, perhaps you need to implement one of them:
           candidate #1: `actix_web::http::header::Header`
           candidate #2: `time::private::Parsable`
           candidate #3: `Parser`

error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/main.rs:90:18
   |
90 |     if let (Some(tls_cert), Some(tls_key)) = (config_.tls_cert, config_.tls_key) {
   |                  ^^^^^^^^ doesn't have a size known at compile-time
   |
   = help: within `std::path::Path`, the trait `std::marker::Sized` is not implemented for `[u8]`
   = note: required because it appears within the type `std::path::Path`
   = note: all local variables must have a statically known size
   = help: unsized locals are gated as an unstable feature

error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
  --> .cargo/registry/src/github.com-1ecc6299db9ec823/proxyboi-0.5.0/src/main.rs:90:34
   |
90 |     if let (Some(tls_cert), Some(tls_key)) = (config_.tls_cert, config_.tls_key) {
   |                                  ^^^^^^^ doesn't have a size known at compile-time
   |
   = help: within `std::path::Path`, the trait `std::marker::Sized` is not implemented for `[u8]`
   = note: required because it appears within the type `std::path::Path`
   = note: all local variables must have a statically known size
   = help: unsized locals are gated as an unstable feature

Some errors have detailed explanations: E0277, E0432, E0599.

I though the value should be 0,1 2 and 3. And C uses level 2 and level 3 should not be used in sensitive system like rockets and satellites?

But this z confused me and cargo docs also don't show me.

It would be so nice to add request headers (e.g. Authorization) to the upstream with a --request-header parameter similar to --response-header. 👍

Hello. I discovered proxyboi recently, and I find it really convenient for testing and whatnot. My issue is that when sending really large packets, the proxy doesn't forward the request to the upstream and instead just returns A payload reached size limit.
If the request is under limit, but the response is too big, then I get the following error:

13:48:28 [ERROR] Unknown Internal Error
13:48:28 [ERROR] Internal Server Error: PayloadError(Overflow)

I think it would be beneficial to add options for changing the limits on the sizes of requests and responses.

If I try to proxy to a local ip with an https server running, e.g. https://1.2.3.4, proxyboi crashes with the following message:

thread 'actix-rt:worker:0' panicked at 'rustls currently only handles hostname-based connections. See https://github.com/briansmith/webpki/issues/54: InvalidDNSNameError', /cargo/registry/src/github.com-1ecc6299db9ec823/actix-connect-2.0.0/src/ssl/rustls.rs:107:14

For what it's worth, rustls forked the webpki repo and is including the fix in the upcoming 0.21.0 release (rustls/rustls#184) -- so you might want to rebuild with that soon

would be great to be able to use this as a lib in another program

It might be handy to send extra headers to the upstream proxy such as auth. Maybe even add an auth nicety.

Given that one can manually add additional headers via the --upstream-header option, I think it'd be reasonable to avoid setting the forwarded-for header by default. I.e. the assumption is the proxy should resend the request from the client exactly, just replacing the Host header.

Copy from miniserve and genact.

Example usage: $ proxyboi https://upstream.com --listen 0.0.0.0:8000 --upstream-header 'Origin: https://mysite.com'

If the server takes longer than 5 seconds to respond to a request the proxy times out. It would be useful to be able to increase this timeout.

> curl -O https://github.com/svenstaro/proxyboi/releases/download/v0.5.0/proxyboi-v0.5.0-linux-x86_64
> chmod +x ./proxyboi-v0.5.0-linux-x86_64
> ./proxyboi-v0.5.0-linux-x86_64
Failed to execute process './proxyboi-v0.5.0-linux-x86_64'. Reason:
exec: Exec format error
The file './proxyboi-v0.5.0-linux-x86_64' is marked as an executable but could not be run by the operating system.

I cloned the repo and built a release build via cargo build --release and that one runs perfectly:

> ./target/release/proxyboi
error: The following required arguments were not provided:
    <upstream>

USAGE:
    proxyboi <upstream> --listen <listen> --timeout <timeout>

For more information try --help

# uname -a
Linux minirack 5.4.0-74-generic #83-Ubuntu SMP Sat May 8 02:35:39 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

# rustc --version
rustc 1.51.0 (2fd73fabe 2021-03-23)

# cargo --version
cargo 1.51.0 (43b129a20 2021-03-16)

Getting the headers inside the request doesn't give us the final headers because actix changes them while sending. We should use a middleware to fix that.

I built the docker image and then wanted to start it through this command:

docker run proxyboi -l ip:4430 http://ip:8501
and then got this error:
Error: Os { code: 99, kind: AddrNotAvailable, message: "Address not available" }

For "ip" i wrote the ip adress of my server where actually an http application is running on port 8501. I would like to listen to port 4430 (tls) and this should be forwarded to port 8501 and give the content from this application back. With ssl -proxy in the windows console it worked.

Could it be, that this implementation does not support ip adresses but only domain names?

Currently, we don't print the body. It might be helpful, however.

Does this lib support reverse proxy websocket by adding Upgrade header?