Nested states that transition to themselves look weird about state-machine-cat HOT 10 CLOSED

@LevelbossMike I haven't released it yet - have to do some juggling in the dot reporter to get to the result. I'll let you know in this thread when I have something testable ready.

from state-machine-cat.

@LevelbossMike thanks for raising this issue, and yes, that needs to be improved. (also the self-transitions from non-nested entities have become a bit too tiny for my taste since the last major change). I'll try to tweak the output into submission.

Your add-on looks cool and very useful 👍 - wish something like this would exist for angular...

(And thanks for the compliments 😊 )

from state-machine-cat.

Intermediate update: below you see the current situation and what I came up with after some graphviz trickery:

ns {
    s => s: hi;
};

ns => ns: hi;

from state-machine-cat.

this looks great! Is this already released? I still see the old behavior in the web-editor

from state-machine-cat.

I found a solution for this issue, but it seems to only be applicable to fdp.
You need to use splines=compound instead of splines=true,
and the state transitions/edges have to start/end on the "cluster_" node instead of the invisible helper node inside the cluster, as is currently done. The lhead="cluster_" inside the brackets has to/should be removed.
It might be necessary to also remove rankdir=LR and add overlap=scale, at least those seem to have solved it for me.

from state-machine-cat.

Thanks @namibj! - I'll tweak the fdp output specifically to include you recommendations in a separate PR. (I wish we could do the same for dot!)

For the dot (and probably the osage) algorithm I'm afraid we're stuck with another helper node to guide the self transition outside the clustered node...

from state-machine-cat.

hi @LevelbossMike - a ping as promised: the PR above tries to fix the issue. I've published a first beta version:

• on npm (as [email protected] in the beta channel)
• on https://state-machine-cat.js.org/dev (beware: this will load slower than the regular site as it contains debugging information, source maps - and is not minified to boot)

I've already found two kinks to iron out (see the PR - @namibj already pointed out one of em) - but am curious if this works well enough for your scenario(s).

from state-machine-cat.

Update: just deployed a fix for the first of the two kinks (with direction left-right and right-left self transitions to composite states look sorta ok now as well) and published them on npm ([email protected]) and on https://state-machine-cat.js.org/dev.

from state-machine-cat.

@sverweij looks great 🍻 👍

from state-machine-cat.

@LevelbossMike I've merged the PR, released to npm as 4.1.5 and to the main branch on state-machine-cat.js.org.

Thanks again for raising the issue and for the prompt feedback!

from state-machine-cat.