Comments (3)
@jmarr I appreciate the detailed writeup. I'm unlikely to look at this anytime soon given that it is an obscure problem and you have a workaround. Hopefully it will resolve itself in a future version of iOS.
from swiftmessages.
@wtmoose Thanks and yeah, that's totally understandable. I mostly wanted to post it here in case anyone else runs into the issue, since it took a while to discover thatoverrideUserInterfaceStyle
was triggering it.
In our app the issue was much more noticeable because we have a container view with a bottom bar that sets additionalSafeAreaInsets
on its children, so the message was appearing entirely behind the bar.
And yes, hopefully the underlying issue will be resolved in an iOS update, though I did verify it's still happening on the latest iOS 17.1 beta.
from swiftmessages.
I just discovered that this issue also occurs when showing a message from a view controller that's being presented.
- Build and run this project on a device with safe areas.
- Tap
Show Message
and note that the message respects the safe area. - Tap
Present View Controller
. - Tap
Show Message
and note that the message overlaps the safe area.
The issue doesn't occur if I change the presentationContext
from .viewController(self)
to .window(windowLevel: .normal)
In stepping through the code, after calling container.layoutIfNeeded()
on line 100 of TopBottomAnimation.swift
, the frame of container
is changed and no longer overlapping the safe area, so the safe area isn't taken into account by the call to adjustMargins
, just like when overrideUserInterfaceStyle
was used.
from swiftmessages.
Related Issues (20)
- Identifiable collision HOT 1
- No such module 'SwiftMessages' HOT 2
- Crash while clicking two times to hide the presenting controller HOT 3
- SwiftUI View ignoresSafeArea HOT 4
- SwiftMessages custom CenteredView extends to the screen's full height HOT 3
- How can I show multiple alert? HOT 2
- How do I show a message that appears above the keyboard, when the keyboard is already visible? HOT 5
- Xcode warnings in two swift files HOT 2
- window being accessed from background thread when dequeueNext is called HOT 12
- EventListeners not called ? HOT 5
- Support for SwiftUI Mac OS HOT 1
- SwiftUI message shown under navigation bar is clipped at top HOT 1
- issue with building for device HOT 1
- Breaking change released in patch release HOT 10
- why didHide Source dismiss? HOT 3
- Cannot build on physical device but can on a simulator. HOT 1
- Support App Privacy Manifest HOT 1
- Message opened via SwiftMessagesSegue closes by itself after 2 seconds (regression, appeared in 9.0.7) HOT 3
- Add Privacy manifests file HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftmessages.