Comments (10)
wtmoose
commented on June 12, 2024
1
Oh, I misread. You want me to change the version number. Yeah, I'll probably do that.
from swiftmessages.
Mordil
commented on June 12, 2024
1
Then please document in your README that you’re not SemVer compliant so others may know
from swiftmessages.
Mordil
commented on June 12, 2024
There are technically a few breaking changes within this release.
Please release a 9.0.11 reverting these changes and re-release as 10.0.0
from swiftmessages.
wtmoose
commented on June 12, 2024
Yep, that was a mistake. It didn't occur to me that this was a breaking change. However, I don't think I'm going to revert – I'm not going to avoid new technologies because a small subset of projects aren't adopting them.
from swiftmessages.
jarrodlombardo-EventBase
commented on June 12, 2024
Please rename the tag ASAP since it's breaking people's apps ~now.
from swiftmessages.
jarrodlombardo-EventBase
commented on June 12, 2024
Thanks :D
from swiftmessages.
wtmoose
commented on June 12, 2024
There are technically a few breaking changes within this release.
@Mordil what else did you note as a breaking change? I'm contemplating re-releasing the as 9.0.10, but without @MainActor. So if you have other concerns, please share.
from swiftmessages.
Mordil
commented on June 12, 2024
There are technically a few breaking changes within this release.
@Mordil what else did you note as a breaking change? I'm contemplating re-releasing the as 9.0.10, but without
@MainActor. So if you have other concerns, please share.
It's arguable this doesn't count, but I believe changing the minimum supported platform to iOS 13 is itself a breaking change, because people will stop receiving updates if they have iOS 12 or earlier as their minimum - which breaks expectations of patch releases.
from swiftmessages.
jarrodlombardo-EventBase
commented on June 12, 2024
Yes, any increase to minimum iOS version is always a breaking change. My team was hitting an issue with @MainActor and also nonisolated breaking the builds in our apps.
from swiftmessages.
wtmoose
commented on June 12, 2024
I'm keeping @MainActor, so I'll be moving to 10.0.0. However, while I agree that bumping the minimum target is technically a breaking change, practically, I would not bump the major version for that given how few people would be affected, it would not be worth the tradeoff.
from swiftmessages.
Related Issues (20)
- Crash while clicking two times to hide the presenting controller HOT 3
- SwiftUI View ignoresSafeArea HOT 4
- SwiftMessages custom CenteredView extends to the screen's full height HOT 3
- How can I show multiple alert? HOT 2
- Safe area insets are not respected when setting overrideUserInterfaceStyle on a MessageView in iOS 17 HOT 3
- How do I show a message that appears above the keyboard, when the keyboard is already visible? HOT 5
- Xcode warnings in two swift files HOT 2
- window being accessed from background thread when dequeueNext is called HOT 12
- EventListeners not called ? HOT 5
- Support for SwiftUI Mac OS HOT 1
- SwiftUI message shown under navigation bar is clipped at top HOT 1
- issue with building for device HOT 1
- why didHide Source dismiss？ HOT 3
- Cannot build on physical device but can on a simulator. HOT 1
- Support App Privacy Manifest HOT 1
- Message opened via SwiftMessagesSegue closes by itself after 2 seconds (regression, appeared in 9.0.7) HOT 3
- Add Privacy manifests file HOT 11
- Create a formal dismissal mechanism for SwiftUI message
- Why do you call this SwiftMessages? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from swiftmessages.