swiftsnamesake / 3dwaves Goto Github PK

Make sure the formatting is consistent. For example, the section dividers.

The face parser shouldn't accept differing vertex definitions (eg. "f 1 4/2 4/2"). A face either has normals and texture coordinates, or it doesn't.

Maybe it would be better to use a union for the VertexIndices type.

It also shouldn't default to Nothing when failing to parse an index.

Nice haddocks

Write proper tests (cf. Criterion and QuickCheck).

The current implementation uses attoparsec, which is efficient but less capable of generating detailed and helpful error messages.

We should consider adding another parsing mode (possibly using Parsec instead), which is capable of locating and perhaps even suggesting fixes to malformed data.

Fix the typos, add documentation

Case in point:

We obviously can't depend on packages that are assumed to be stored locally at a particular path (eg. Cartesian and Leibniz)