syberalexis / puppet-thanos Goto Github PK
View Code? Open in Web Editor NEWThis module automates the install of Thanos and it's components into a service.
Home Page: https://forge.puppet.com/maeq/thanos
License: Apache License 2.0
This module automates the install of Thanos and it's components into a service.
Home Page: https://forge.puppet.com/maeq/thanos
License: Apache License 2.0
Is your feature request related to a problem? Please describe.
I am running thanos services with the prometheus user (RHEL/CentOS OS). But I have an issue with the thanos config dir always owned by 'root'. I don't understand why, is there a reason behind this?
Describe the solution you'd like
Support to set the 'config_dir' owner to the user running thanos.
Describe alternatives you've considered
I don't see any
Additional context
Here is the exact place this is done:
puppet-thanos/manifests/install.pp
Line 128 in a59248a
In Thanos version v0.13.0 invocation for thanos bucket web
has been changed thanos-io/thanos#2513.
Valid execution should be thanos tools bucket web
.
We have at least two options to fix it in Puppet:
tools
in https://github.com/syberalexis/puppet-thanos/blob/master/manifests/bucket_web.pp#L71manifests/bucket_web.pp
should be manifests/bucket_tools_web.pp
...Is your feature request related to a problem? Please describe.
I am running version 6.1.0 of puppet-archive and puppet-thanos fails because it supports up to version 5.0.0.
The version of puppet-archive as of this writing is v6.1.1.
Describe the solution you'd like
Add support for puppet-archive to include v6.1.1.
Describe alternatives you've considered
None.
Additional context
None.
Is your feature request related to a problem? Please describe.
I want to run the Thanos sidecar without specifying an object store.
This mode is supported in the Thanos documentation
but it is not supported in puppet-thanos.
Describe the solution you'd like
Ability to start the sidecar without specifying the --objstore.config-file
or puppet-thanos setting a default value.
Describe alternatives you've considered
None.
Additional context
None.
Starting to v0.16.0, a breaking change has been introduced related to query-frontend log_queries_longer_than
which has been renamed to log-queries-longer-than
(thanos-io/thanos#3114)
Here's the pull request to fix it, if you can take some time to check it / merge it ๐ (apparently the tests fails due to timeout...)
Hi,
Would it be possible to add support for Thanos v0.26.0?
For instance, manifests/sidecar.pp has now 2 flags that are not supported and prevent the process to start:
receive.connection-pool-size
receive.connection-pool-size-per-host
Rename stores
to endpoints
for the querier as store
is now deprecated
Also, it would be great to allow the module increasing the number of file descriptor the process can open (1024 by default)(https://thanos.io/tip/operating/binary-index-header.md/#impact-on-number-of-open-file-descriptors)
Describe the bug
Release 1.6.0 is not available on Puppet Force
To Reproduce
https://forge.puppet.com/modules?limit=25&sort_by=rank&module_groups=base%20pe_only&q=thanos
Expected behavior
All releases should be present on Puppet Forge.
Environment
N/A
This causes the systemd to not take the service file change into account when reloading the service afterwards.
I am working on a PR for this.
Is your feature request related to a problem? Please describe.
It is possible to specify the query.replica-label multiple times and their usecase is also documented.
It's currently not easily possible to specify the query.replica-label multiple times.
Describe the solution you'd like
It should be possible to specify the param multiple times e.g.
thanos::query::query_replica_label:
- "replica"
- "tenant_id"
Describe alternatives you've considered
I'm currently using the following workaround:
---
thanos::query::extra_params:
query.replica-label: "tenant_id --query.replica-label=replica"
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.