synapsestudios / kohana-notices Goto Github PK

Secure by default. Prevents XSS. Make a way to send raw if needed.

I was wondering whether you would consider adding a media controller to this module, that would serve the media files? Akin to what is used in the userguide. Doing so would mean that one could include the module without having to do anything (i.e. copy any files anywhere), and so updates would be simpler.

Just an idea (because I want to use this module!).

Thanks!

It seems like the close image is not high enough on the notice bar. I would expect it to be closer to the top right rather than having it be around the middle of the notice bar.

you should not have an tag in your notice output for the type of notice... this is equivalent to the bullets in an unordered list! It's purely a style of the notice! This also simplifies the adding of the image... as you can force the convention of the css and img folders being next to each other and use relative paths
.error images will always be ../img/error.png (or whatever convention you want to set)

Is this "usable" when you use default caching from Kohana? I had some strange experiences with sessions and default cache in the past.

Would it be cleaner to add a class to the close button to inform the js file which notices are persistent and require the ajax calls to remove? Regular notices can simply be hidden.

Reported by @boxyman:

Am I mistaken or does the documetation not match for the dev/3.0.x branch?

E.g. doesn't work and I cannot see the function anywhere in the source code.

Anyways dev/2.1 seems to work fine with Kohana 3.1.3.1

Thanks.

The close button should be added with JS if it can only be done with ajax calls.

Shouldn't the notices/remove action be allowed to be called without ajax in order to remove a persistent notice without requiring JS?

We should avoid treading on the kohana namespace in our modules in case they ever make something that uses that. So Notice extends Kohana_Notice should probably be changed to something like Notice extends Synapse_Notice