syscrusher / fake Goto Github PK

not sure if it's an issue, but I've noticed locking in the lookup method:

func lookup(lang, cat string, fallback bool) string {
    samplesLock.Lock()
    s := _lookup(lang, cat, fallback)
    samplesLock.Unlock()
    return s
}

does it mean it's kind of a synchronous access? If so, is there any chance to provide non-locking implementation? As for the parallel world it sounds like a bad idea.

having:

package main

import (
    "fmt"
    "github.com/syscrusher/fake"
)

func main() {
    fmt.Println(fake.CreditCardNum(""))
}

results in something like: 6011
which doesn't seem to be a valid credit card number.

I'd expect it to match regex: ^[0-9]{4}(-[0-9]{4}){3}$