szantaii / bash-weather Goto Github PK

I don't know if you take feature request, but since you respond so fast:

coloured output would be really nice to have. As in, a yellow sun, grey clouds, and so on.

Seems like I'll be having down to -1°C tomorrow…
/print-forecast.sh: line 104: printf: -1: invalid option printf: usage: printf [-v var] format [arguments]
A solution would be to use echo or printf "%s" for all the day?_min/max_temperature output.

Within the last few days, the app stopped fetching the weather data. The program runs without error, but just doesn't display the actual weather.
Reviewing the get-weather-data.sh file, I added an API key to the end of each URI listed (two occurrences each of current_weather_data and weather_forecast_data), in the form of APPID=. For example, this:
current_weather_data=$(curl -s "http://api.openweathermap.org/\
data/2.5/weather?lat=${latitude}&lon=${longitude}&mode=xml&
units=${unit_type}&APPID=")

Of course, this means that you have to sign up for an API key with openweathermap.org, so you have an API key to enter here. I will probably end up pulling the key from a file long term, but I thought I would mention it here to see if you had a better idea on handling the issue.