szepeviktor / acf-custom-database-tables-test Goto Github PK

@mishterk Would you welcome a patch for Advanced Custom Fields: Custom Database Tables?

After reading you are working on 1.1 I thought these would definitely help.

• use the static analysis in this repo, start command: composer install && vendor/bin/phpstan analyze -l 0
• PHP 7.2 is recommended
• there is a bug in it: you have to remove is_countable() stub at vendor/giacocorsiglia/wordpress-stubs/wordpress-stubs.php:73532
• please add proper PHPDoc blocks for properties and methods (currently in ignoreErrors:)
• define all properties before usage (currently in ignoreErrors:)
• PHPStan's output will guide you towards robust code!

An advise: start at Level 0 -l 0 and raise it gradually.

btw. the current version has a big typo at src/app/Controller/UpdateTablesFormController.php:84 it should be $cache->get_error_messages();