Giter VIP home page Giter VIP logo

atom-isearch's Introduction

personal image registories for my oss project

atom-isearch's People

Contributors

t9md avatar

Stargazers

avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

tmunro

atom-isearch's Issues

Uncaught TypeError: Cannot convert undefined or null to object

Initiating any search via isearch:search-forward immediately yields this error. The package thus basically unusable as of now. Many thanks for looking into this.

Atom Version: 1.3.0
System: Mac OS X 10.11.2
Thrown From: isearch package, v0.1.12

Stack Trace

Uncaught TypeError: Cannot convert undefined or null to object

At /Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:133

TypeError: Cannot convert undefined or null to object
    at Function.keys (native)
    at MarkerLayer.module.exports.MarkerLayer.findMarkers (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/text-buffer/lib/marker-layer.js:133:21)
    at DisplayBuffer.module.exports.DisplayBuffer.findFoldMarkers (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1143:36)
    at Object.module.exports.saveEditorState (/Users/grust/.atom/packages/isearch/lib/main.coffee:226:44)
    at Object.module.exports.start (/Users/grust/.atom/packages/isearch/lib/main.coffee:51:40)
    at atom-text-editor.subscriptions.add.atom.commands.add.isearch:search-forward (/Users/grust/.atom/packages/isearch/lib/main.coffee:30:26)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:260:29)
    at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:536:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:359:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:99:36)
    at HTMLDocument.<anonymous> (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:3:61)

Commands

     -5:03.1.0 core:backspace (atom-text-editor.editor.is-focused)
     -5:02.9.0 core:save (atom-text-editor.editor.is-focused)
     -0:48.2.0 script:run (atom-text-editor.editor.is-focused)
     -0:29 core:save (atom-text-editor.editor.is-focused)
     -0:28.8.0 script:run (atom-text-editor.editor.is-focused)
     -0:23.6.0 core:move-right (atom-text-editor.editor.is-focused)
  4x -0:23.2.0 core:backspace (atom-text-editor.editor.is-focused)
     -0:21.6.0 core:save (atom-text-editor.editor.is-focused)
     -0:20.8.0 core:move-right (atom-text-editor.editor.is-focused)
     -0:20.5.0 core:backspace (atom-text-editor.editor.is-focused)
  2x -0:20.4.0 core:save (atom-text-editor.editor.is-focused)
     -0:16.9.0 isearch:search-forward (atom-text-editor.editor.is-focused)
     -0:08.2.0 blur (atom-text-editor.editor.is-focused)
     -0:08.1.0 click (div.close.icon.icon-x)
  2x -0:08.1.0 blur (atom-notification.fatal.icon.icon-bug.native-key-bindings.has-detail.has-close.has-stack.remove)
     -0:01.1.0 isearch:search-forward (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "atom-dark-syntax"
    ],
    "useReactEditor": false,
    "disabledPackages": [
      "atom-alignment",
      "metrics"
    ],
    "packagesWithKeymapsDisabled": [
      "autocomplete-plus"
    ]
  },
  "isearch": {}
}

Installed Packages

# User
asciidoc-preview, v0.6.0
autocomplete-haskell, v0.6.2
file-icons, v1.6.13
file-types, v0.5.1
foldingtext-for-atom, v0.9.2
goto-last-edit, v0.2.2
haskell-ghc-mod, v1.2.0
haskell-pointfree, v0.1.2
highlight-selected, v0.11.1
ide-haskell, v1.3.7
ide-haskell-cabal, v1.0.0
isearch, v0.1.12
language-asciidoc, v0.12.0
language-fish-shell, v1.0.2
language-haskell, v1.5.1
language-jsoniq, v1.7.6
language-latex, v0.6.1
language-llvm, v0.1.1
language-pgsql, v0.2.0
latex, v0.28.2
linter, v1.11.3
markdown-table-formatter, v2.5.5
pdf-view, v0.37.0
red-wavy-underline, v0.3.0
script, v3.2.0

# Dev
No dev packages

Uncaught TypeError: editor.displayBuffer.findFoldMarkers is not a function

The error happens whenever I run isearch. This is the Stack Trace (I'm using Atom 1.9.0 and isearch 0.1.13):

/C:/Users/User/.atom/packages/isearch/lib/utils.coffee:11
Hide Stack Trace
TypeError: editor.displayBuffer.findFoldMarkers is not a function
    at saveEditorState (file:///C:/Users/User/.atom/packages/isearch/lib/utils.coffee:7:40)
    at Object.module.exports.start (file:///C:/Users/User/.atom/packages/isearch/lib/main.coffee:34:29)
    at atom-text-editor.subscriptions.add.atom.commands.add.isearch:search-forward (file:///C:/Users/User/.atom/packages/isearch/lib/main.coffee:22:38)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\User\AppData\Local\atom\app-1.9.0\resources\app.asar\src\command-registry.js:260:29)
    at C:\Users\User\AppData\Local\atom\app-1.9.0\resources\app.asar\src\command-registry.js:3:61
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (C:\Users\User\AppData\Local\atom\app-1.9.0\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:580:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\User\AppData\Local\atom\app-1.9.0\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:388:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (C:\Users\User\AppData\Local\atom\app-1.9.0\resources\app.asar\src\window-event-handler.js:98:36)
    at HTMLDocument.<anonymous> (C:\Users\User\AppData\Local\atom\a

Smart Case does not quite work with vim-mode-next history

Regular searching does just fine. In vim-mode-next, I can type anything lower case or mixed case and find it, hit enter, and then use vim's "n" command to find the next occurrence (this is with Smart Case checked). However, once I try to perform a Smart Case search (it works), hit enter, and then type "n", it's like the history has been deleted. I suspect this is because it places the lower case version into the history, so when I try to do a repeat search, it searches only for the lower case version.

Uncaught Error: This TextEditor has been destroyed

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.0.2
System: Mac OS X 10.10.4
Thrown From: isearch package, v0.1.11

Stack Trace

Uncaught Error: This TextEditor has been destroyed

At /Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1098

Error: This TextEditor has been destroyed
  at DisplayBuffer.module.exports.DisplayBuffer.screenPositionForBufferPosition (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:1098:15)
  at DisplayBuffer.module.exports.DisplayBuffer.screenRangeForBufferRange (/Applications/Atom.app/Contents/Resources/app.asar/src/display-buffer.js:956:20)
  at Marker.module.exports.Marker.getScreenRange (/Applications/Atom.app/Contents/Resources/app.asar/src/marker.js:141:33)
  at Match.scroll (/Users/rpietro/.atom/packages/isearch/lib/match.coffee:34:27)
  at MatchList.redraw (/Users/rpietro/.atom/packages/isearch/lib/match.coffee:103:13)
  at MatchList.visit (/Users/rpietro/.atom/packages/isearch/lib/match.coffee:77:6)
  at Object.module.exports.start (/Users/rpietro/.atom/packages/isearch/lib/main.coffee:39:16)
  at atom-text-editor.subscriptions.add.atom.commands.add.isearch:search-forward (/Users/rpietro/.atom/packages/isearch/lib/main.coffee:21:38)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:520:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:355:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands

     -0:04.3.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -0:04.3.0 core:cancel (atom-text-editor.editor.is-focused)
     -0:02.0 isearch:search-forward (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "base16-tomorrow-light-theme"
    ],
    "disabledPackages": [
      "markdown-preview-plus",
      "language-pfm",
      "atom-terminal"
    ]
  },
  "isearch": {}
}

Installed Packages

# User
autocomplete-bibtex, v0.5.7
isearch, v0.1.11
language-dot, v1.6.0
language-todotxt, v0.6.1
markdown-writer, v1.7.1
pandoc, v0.2.2
repl-term, v0.1.4
sort-lines, v0.11.0
toggle, v0.2.3

# Dev
No dev packages

Uncaught TypeError: Cannot read property 'getCurrent' of null

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.0.3
System: Mac OS X 10.10.4
Thrown From: isearch package, v0.1.12

Stack Trace

Uncaught TypeError: Cannot read property 'getCurrent' of null

At /Users/rpietro/.atom/packages/isearch/lib/main.coffee:92

TypeError: Cannot read property 'getCurrent' of null
  at Object.module.exports.land (/Users/rpietro/.atom/packages/isearch/lib/main.coffee:92:21)
  at isearch-ui.UI.confirm (/Users/rpietro/.atom/packages/isearch/lib/ui.coffee:78:11)
  at atom-text-editor.subscriptions.add.atom.commands.add.core:confirm (/Users/rpietro/.atom/packages/isearch/lib/ui.coffee:31:29)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands

     -0:16.5.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:16.3.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:16.3.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:16 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:16 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.8.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.8.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.6.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.6.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.3.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.3.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.1.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:15.1.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:14.9.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:14.9.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)
     -0:02.0 core:confirm (atom-text-editor.editor.isearch.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "base16-tomorrow-light-theme"
    ],
    "disabledPackages": [
      "markdown-preview-plus",
      "language-pfm",
      "atom-terminal",
      "incremental-search"
    ]
  },
  "isearch": {}
}

Installed Packages

# User
autocomplete-bibtex, v0.5.7
isearch, v0.1.12
language-todotxt, v0.6.1
repl-term, v0.2.2
sort-lines, v0.11.0
tidy-markdown, v1.0.0

# Dev
No dev packages

Changes to TextEditor.onDidChange and TextBuffer.onDidChange coming in Atom 1.23

Hi! Thanks for maintaining the isearch package!

In Atom v1.23, we will some changes that may affect your package.

The methods TextEditor.onDidChange and TextBuffer.onDidChange will now call their callbacks less frequently. Previously, these callbacks would get called once for each individual change to the buffer. So if you had 5 cursors and typed a character, they would get called 5 times. Now, they will only get called once, and the event that is passed to them will contain information about all 5 of the changes that have occurred.

The same properties that have always existed on the TextBuffer.onDidChange events (oldRange, newRange, oldText, and newText) will still be there, and they will now reflect the sum of all changes that have occurred. But now there will be an additional property called changes, which will contain an array of more fine-grained objects describing the individual changes. We encourage you to use this property instead of the old ones.

Effects on this package

It looks like this package calls the changed methods in the following places:

  • TextEditor.onDidChange

We found these calls using a regex search, so this list might be incomplete, and it might contain some false positives.

What to do about the change

It is likely that you do not need to do anything. The old event properties will continue to work.

However, you may be able to handle changes more accurately and efficiently by using the changes field of the events rather than the old properties. The changes field does not exist in Atom 1.22 unless you use the TextBuffer.onDidChangeText method. In Atom 1.23 and above though, .onDidChange and .onDidChangeText will become identical, having both the old properties and the new changes property.

Please let me know if you have any questions. I would be happy to help!

Uncaught TypeError: object is not a function

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.0.3
System: Mac OS X 10.10.4
Thrown From: isearch package, v0.1.11

Stack Trace

Uncaught TypeError: object is not a function

At /Users/rpietro/.atom/packages/isearch/lib/main.coffee:87

TypeError: object is not a function
  at Object.module.exports.cancel (/Users/rpietro/.atom/packages/isearch/lib/main.coffee:87:6)
  at isearch-ui.UI.cancel (/Users/rpietro/.atom/packages/isearch/lib/ui.coffee:87:11)
  at atom-text-editor.subscriptions.add.atom.commands.add.core:cancel (/Users/rpietro/.atom/packages/isearch/lib/ui.coffee:33:29)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands

     -0:56.2.0 settings-view:open (atom-text-editor.editor.is-focused)
     -0:04.3.0 editor:consolidate-selections (atom-text-editor.editor.isearch.mini.is-focused)
     -0:04.3.0 core:cancel (atom-text-editor.editor.isearch.mini.is-focused)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "base16-tomorrow-light-theme"
    ],
    "disabledPackages": [
      "markdown-preview-plus",
      "language-pfm",
      "atom-terminal",
      "isearch",
      "incremental-search"
    ]
  },
  "isearch": {}
}

Installed Packages

# User
autocomplete-bibtex, v0.5.7
language-todotxt, v0.6.1
repl-term, v0.1.4
sort-lines, v0.11.0
tidy-markdown, v1.0.0

# Dev
No dev packages

Uncaught TypeError: Cannot read property 'isEmpty' of null

[Enter steps to reproduce below:]

  1. ...
  2. ...

Atom Version: 1.0.3
System: Mac OS X 10.10.4
Thrown From: isearch package, v0.1.12

Stack Trace

Uncaught TypeError: Cannot read property 'isEmpty' of null

At /Users/rpietro/.atom/packages/isearch/lib/main.coffee:38

TypeError: Cannot read property 'isEmpty' of null
  at Object.module.exports.start (/Users/rpietro/.atom/packages/isearch/lib/main.coffee:38:25)
  at atom-text-editor.subscriptions.add.atom.commands.add.isearch:search-forward (/Users/rpietro/.atom/packages/isearch/lib/main.coffee:21:38)
  at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:241:29)
  at /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:61
  at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:524:16)
  at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:347:22)
  at HTMLDocument.module.exports.WindowEventHandler.onKeydown (/Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:177:20)

Commands

 29x -1:45.7.0 core:move-up (atom-text-editor.editor.is-focused)
     -1:41 find-and-replace:show (atom-text-editor.editor.is-focused)
     -1:38.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:35.2.0 editor:move-to-first-character-of-line (atom-text-editor.editor.is-focused)
  7x -1:33.2.0 editor:select-to-end-of-word (atom-text-editor.editor.is-focused)
     -1:31.2.0 core:select-right (atom-text-editor.editor.is-focused)
     -1:30.2.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:28.6.0 sort-lines:sort (atom-text-editor.editor.is-focused)
     -1:27.5.0 core:save (atom-text-editor.editor.is-focused)
     -1:25.9.0 editor:consolidate-selections (atom-text-editor.editor.is-focused)
     -1:25.9.0 core:cancel (atom-text-editor.editor.is-focused)
     -1:23 settings-view:open (atom-text-editor.editor.is-focused)
     -1:11.1.0 core:close (div.settings-view.pane-item)
     -1:09.1.0 isearch:search-forward (atom-text-editor.editor.is-focused)
  2x -1:00.0 settings-view:check-for-package-updates (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-base16-tomorrow-light-theme.theme-one-dark-ui)
     -0:03.2.0 isearch:search-forward (atom-text-editor.editor.is-focused)

Config

{
  "core": {
    "themes": [
      "one-dark-ui",
      "base16-tomorrow-light-theme"
    ],
    "disabledPackages": [
      "markdown-preview-plus",
      "language-pfm",
      "atom-terminal",
      "incremental-search"
    ]
  },
  "isearch": {}
}

Installed Packages

# User
autocomplete-bibtex, v0.5.7
isearch, v0.1.12
language-todotxt, v0.6.1
repl-term, v0.2.2
sort-lines, v0.11.0
tidy-markdown, v1.0.0

# Dev
No dev packages

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.